New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(IE11): Platform & Docs support for IE11 #831
Conversation
…prefixed for every browser.
Added a few things:
The last one will make sure we dont have CSS issues across browsers (for the most part) e.g. SCSS :host {
.td-chips-wrapper {
display: flex;
flex-direction: row;
flex-wrap: wrap;
align-items: flex-start;
}
} Compiled CSS without autoprefixer: :host .td-chips-wrapper {
display: flex;
flex-direction: row;
flex-wrap: wrap;
align-items: flex-start;
} Compiler CSS with autoprefixer: :host .td-chips-wrapper {
display: -webkit-box;
display: -ms-flexbox;
display: flex;
-webkit-box-orient: horizontal;
-webkit-box-direction: normal;
-ms-flex-direction: row;
flex-direction: row;
-ms-flex-wrap: wrap;
flex-wrap: wrap;
-webkit-box-align: start;
-ms-flex-align: start;
align-items: flex-start;
} |
nice! thx @emoralesb05! |
Pushed a fix for the chips alignment issue 025e79b |
Edit: Fixed in 2c41491 Form in expantion panel documentation is overlapping in IE. Edit: Fixed in a37e79c Also affects tdLoading demo |
…snt get spaced when stacked
Update: Fixed in dd76149 Prompt dialog buttons are being pushed up into the input. |
fix for the prompt dialog pushed ref: #831 (comment) |
fix loading demo issue in IE11 a37e79c |
fixed expansion panel form height issue with 2c41491 ref #831 (comment) |
fixed dynamic form overlap with e9ac1b6 ref: #831 (comment) |
fixed the data-table sorting arrow jumping around in IE11 b4a06c8 |
fixed an additional issue with md-select paging width in ie11 d088a87 |
I think this is a good enough base for now. If there are any other IE11 (which there are) we should open specific issues in the repo so we can tackle them separately. Gonna merge this one for now. |
👏 Thanks for this work. IE11 support is still a requirement for TD ITS projects so this is very helpful. |
Description
Following the Flexbox quirks & lack of full support documented here, this PR has small fixes & workarounds for several components and documentation app areas, as well as IE11 docs for necessary polyfills and workarounds.
What's included?
IE11 VM for OSX/macOS
tar xf IE11.Win8.1.For.Windows.VirtualBox.zip
Test Steps
feature/ie11
rm -rf node_modules
yarn install
ng serve --host 0.0.0.0 --disable-host-check
http://10.0.2.2:4200
Test Covalent
General Tests for Every PR
ng serve --aot
still works.npm run lint
passes.npm test
passes and code coverage is not lower.npm run build
still works.Screenshots or link to CodePen/Plunker/JSfiddle