Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(IE11): Platform & Docs support for IE11 #831

Merged
merged 32 commits into from Aug 30, 2017
Merged

Conversation

kyleledbetter
Copy link
Contributor

@kyleledbetter kyleledbetter commented Aug 25, 2017

Description

Following the Flexbox quirks & lack of full support documented here, this PR has small fixes & workarounds for several components and documentation app areas, as well as IE11 docs for necessary polyfills and workarounds.

What's included?

  • IE11 Docs site fixes
  • IE11 support documentation
  • IE11 fixes for Logo md-icon sizing
  • IE11 fixes for Chips component
  • IE11 fixes for Navigation Drawer component
  • IE11 fixes for Message component
  • IE11 fixes for Notification count component in toolbar
  • IE11 fixes for Layout docs demos (height)
  • IE11 style for layout scss
  • overflow-visible utility style
  • IE11 polyfills for NGX-Charts

IE11 VM for OSX/macOS

Test Steps

  • check out feature/ie11
  • rm -rf node_modules
  • yarn install
  • ng serve --host 0.0.0.0 --disable-host-check
  • in IE11 VM visit http://10.0.2.2:4200

Test Covalent

  • Test Docs homepage and make sure sections are overflowing
  • Test Chips and see that they have proper width
  • Test Message and see that they're properly vertically center
  • Test Notifications and see that the notification icon in the toolbar isn't chopped off
  • Test Navigation drawer and see that it has the proper height (may need browser resize for change detection)
  • Test Layout docs and see they have proper height for demos
  • Test NGX Charts to see that it actually loads (there are card chart issues beyond our fix)
  • Read /docs/IE11.md

General Tests for Every PR

  • ng serve --aot still works.
  • npm run lint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to CodePen/Plunker/JSfiddle

image

image

image

image

image

image

image

image

@emoralesb05 emoralesb05 added this to the Beta.7 milestone Aug 28, 2017
@emoralesb05
Copy link
Contributor

emoralesb05 commented Aug 28, 2017

Added a few things:

  • chore(): update yarn.lock with latest dependencies
  • fix(chips): fix autocomplete click selection for chips
  • chore(build): add autoprefixer to build process to ensure all css is prefixed for every browser.

The last one will make sure we dont have CSS issues across browsers (for the most part)

e.g.

SCSS

:host {
  .td-chips-wrapper {
    display: flex;
    flex-direction: row;
    flex-wrap: wrap;
    align-items: flex-start;
  }
}

Compiled CSS without autoprefixer:

:host .td-chips-wrapper {
    display: flex;
    flex-direction: row;
    flex-wrap: wrap;
    align-items: flex-start;
}

Compiler CSS with autoprefixer:

:host .td-chips-wrapper {
    display: -webkit-box;
    display: -ms-flexbox;
    display: flex;
    -webkit-box-orient: horizontal;
    -webkit-box-direction: normal;
        -ms-flex-direction: row;
            flex-direction: row;
    -ms-flex-wrap: wrap;
        flex-wrap: wrap;
    -webkit-box-align: start;
        -ms-flex-align: start;
            align-items: flex-start;
}

@kyleledbetter
Copy link
Contributor Author

nice! thx @emoralesb05!

@ghost
Copy link

ghost commented Aug 28, 2017

  • Test Docs homepage and make sure sections are overflowing
    Case 1: Chrome (Left) / IE11 (Right) notice overflow break not as clean as Chrome
    rec2
    Case 2: Chrome (Left) / IE11 (Right) notice overflow break not as clean as Chrome
    rec5

@ghost
Copy link

ghost commented Aug 28, 2017

  • Test Chips and see that they have proper width
    Case 1: Chrome (Left) / IE11 (Right) Alignment of chips + chips "Enter auto..." input + remove "X" is not centered
    screen shot 2017-08-28 at 10 57 59 am

@emoralesb05
Copy link
Contributor

Pushed a fix for the chips alignment issue 025e79b

@aciccarello
Copy link
Contributor

aciccarello commented Aug 28, 2017

Edit: Fixed in 2c41491

Form in expantion panel documentation is overlapping in IE.
http://localhost:4200/#/components/expansion-panel

image

Edit: Fixed in a37e79c

Also affects tdLoading demo
http://localhost:4200/#/components/loading

image

@aciccarello
Copy link
Contributor

aciccarello commented Aug 28, 2017

Update: Fixed in dd76149

Prompt dialog buttons are being pushed up into the input.
http://localhost:4200/#/components/dialogs

In IE:
image

In Chrome:
image

@jeremysmartt
Copy link
Collaborator

Strange, clicking in the jump to box causes everything to go away

paging wierd

@jeremysmartt
Copy link
Collaborator

Dynamic Forms looks off:

screen shot 2017-08-28 at 12 15 44 pm

@jeremysmartt
Copy link
Collaborator

Select Boxes look off in IE:

screen shot 2017-08-28 at 12 18 02 pm

@jeremysmartt
Copy link
Collaborator

jeremysmartt commented Aug 28, 2017

SVG from td-readme-loader looks off:

screen shot 2017-08-28 at 12 18 57 pm

@aciccarello
Copy link
Contributor

Data Table

  • Sort icon is mis-aligned and jumps around

ie11 data table sort icon alignment

  • Error and persistant title on row selection

image

Chrome for comparison:
image

  • Icons in data table demo overlap text

image

@kyleledbetter
Copy link
Contributor Author

fix for the prompt dialog pushed
dd76149

ref: #831 (comment)
thx @aciccarello

@emoralesb05
Copy link
Contributor

fix loading demo issue in IE11 a37e79c

@kyleledbetter
Copy link
Contributor Author

fixed expansion panel form height issue with 2c41491

ref #831 (comment)

@kyleledbetter
Copy link
Contributor Author

fixed dynamic form overlap with e9ac1b6

ref: #831 (comment)
thx @jeremysmartt

@kyleledbetter
Copy link
Contributor Author

fixed the data-table sorting arrow jumping around in IE11 b4a06c8

@emoralesb05
Copy link
Contributor

fixed an additional issue with md-select paging width in ie11 d088a87

@emoralesb05
Copy link
Contributor

emoralesb05 commented Aug 30, 2017

I think this is a good enough base for now. If there are any other IE11 (which there are) we should open specific issues in the repo so we can tackle them separately.

Gonna merge this one for now.

@emoralesb05 emoralesb05 merged commit fee4182 into develop Aug 30, 2017
@emoralesb05 emoralesb05 deleted the feature/ie11 branch August 30, 2017 16:57
@aciccarello
Copy link
Contributor

👏 Thanks for this work. IE11 support is still a requirement for TD ITS projects so this is very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants