Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash on placing a prefab with ChangingBlock property #14

Closed
jdrueckert opened this issue Aug 14, 2022 · 3 comments · Fixed by #15
Closed

Crash on placing a prefab with ChangingBlock property #14

jdrueckert opened this issue Aug 14, 2022 · 3 comments · Fixed by #15
Labels
Category: Crash Requests, Issues and Changes targeting unexpected terminations, segfaults, etc. Category: Gameplay Content Requests, Issues and Changes targeting gameplay mechanics and content Good First Issue Good for learners that are new to Terasology Status: Needs Investigation Requires to be checked for feasibility, reproducability, etc. Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Type: Bug Issues reporting and PRs fixing problems

Comments

@jdrueckert
Copy link
Member

How to reproduce

  1. Start Terasology
  2. Select CoreGameplay and add the PlantPack and ChangingBlocks modules in the Advanced Game Setup (AGS)
  3. Open the in-game console (F1) and execute give corn1
  4. Select the new item in your inventory quickslot bar and right-click to place it on a dirt/grass block
  5. Observe Terasology crashing
@jdrueckert jdrueckert added Type: Bug Issues reporting and PRs fixing problems Category: Gameplay Content Requests, Issues and Changes targeting gameplay mechanics and content Category: Crash Requests, Issues and Changes targeting unexpected terminations, segfaults, etc. Good First Issue Good for learners that are new to Terasology Status: Needs Investigation Requires to be checked for feasibility, reproducability, etc. Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness labels Aug 14, 2022
@keturn
Copy link
Contributor

keturn commented Aug 14, 2022

It looks like SimpleUri is what we use for normalized prefab URIs.

@jdrueckert
Copy link
Member Author

jdrueckert commented Aug 14, 2022 •
edited

Thanks for that pointer 👍
It seems our prefab deserialization does not support deserializing into SimpleUris yet 😞
Guess I'll go for some workaround + engine issue and associated in-code TODO...

@jdrueckert jdrueckert mentioned this issue Aug 15, 2022
Merged
1 task
@jdrueckert
Copy link
Member Author

While #15 fixes the ChangingBlocks side of this bug, following the reproduction steps will still lead to a crash.
If tested with MovingBlocks/Terasology#5062, it will no longer crash but still not work yet (and log warnings).
If tested with Terasology/PlantPack#20, it should work.

@jdrueckert jdrueckert mentioned this issue Aug 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Crash Requests, Issues and Changes targeting unexpected terminations, segfaults, etc. Category: Gameplay Content Requests, Issues and Changes targeting gameplay mechanics and content Good First Issue Good for learners that are new to Terasology Status: Needs Investigation Requires to be checked for feasibility, reproducability, etc. Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Type: Bug Issues reporting and PRs fixing problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make ChangingBlocks case insensitive via BlockUri Terasology/ChangingBlocks
2 participants
@keturn @jdrueckert