Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gltf): replace deprecated md5 assets #27

Merged
merged 5 commits into from Oct 31, 2020
Merged

Conversation

jdrueckert
Copy link
Contributor

@jdrueckert jdrueckert commented Oct 27, 2020

How to test

  1. Start a GooKeeper gameplay
  2. Take care that the gooeys don't kill you 馃槄
  3. Use spawnPrefab <prefab> command in the in-game terminal (open via F1) to spawn the following prefabs
  4. Check that the models are visible and the height offset seems about right (fully above the ground but not obviously floating in the air)

@jdrueckert jdrueckert added the Type: Improvement Request for or addition/enhancement of a feature label Oct 27, 2020
@jdrueckert jdrueckert self-assigned this Oct 27, 2020
@jdrueckert
Copy link
Contributor Author

GTLF support

skaldarnar
skaldarnar previously approved these changes Oct 28, 2020
Copy link
Member

@skaldarnar skaldarnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Models are showing up, but there are a few things that are still off:

  • models are moving backwards
  • the hatchling is way bigger than the other gooeys - that seems wrong
  • they all move synchronized (that's likely due to how pathfinding updates entities)

@jdrueckert
Copy link
Contributor Author

Models not moving forward is mentioned in MovingBlocks/Terasology#4156
I'll take another look at the hatchling, probably forgot to fix the scaling.
Synchronized moving might be something @casals could be interested in?

@casals
Copy link

casals commented Oct 28, 2020

IIRC that's pathfinding alright (assuming I understood it correctly). Deer movement (WA + Behaviors) takes that into consideration by (i) randomizing directions (for the next movement) and (ii) probabilistic roll on each deer actually moving for each cycle. I suggest using the stray behavior as a possible solution for sync movement - if (i) + (ii) is an acceptable solution for this case, that's what I'd recommend (at least until we can circle back to Pathfinding).

Copy link
Member

@skaldarnar skaldarnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as all models are visible again.

@jdrueckert the worldly tooltip for the gooey hatchling still does not show anything for me (display names are working fine for the other gooeys).

@casals to clarify, the gooey movement seems to be randomized (they are not walking all in the same direction or such), but they all turn at the same point in time. Nothing critical, just something I noticed...

@skaldarnar skaldarnar merged commit 2555dba into develop Oct 31, 2020
@skaldarnar skaldarnar deleted the feat/replace-md5-gltf branch October 31, 2020 13:55
@jdrueckert
Copy link
Contributor Author

@skaldarnar Right forgot about that tooltip... guess there's a tooltip component missing in the prefab. I'll see about a follow-up PR
Concerning the movement, I opened #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement Request for or addition/enhancement of a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants