Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sabaki: modal dialog for create priv game vs find public game #87

Closed
Terkwood opened this issue Aug 20, 2019 · 3 comments · Fixed by Terkwood/Sabaki#18
Closed

Sabaki: modal dialog for create priv game vs find public game #87

Terkwood opened this issue Aug 20, 2019 · 3 comments · Fixed by Terkwood/Sabaki#18
Labels
enhancement New feature or request

Comments

@Terkwood
Copy link
Owner

Related to #42
@Terkwood Terkwood mentioned this issue Aug 20, 2019
Closed
7 tasks
@Terkwood Terkwood pinned this issue Aug 20, 2019
@Terkwood Terkwood added the enhancement New feature or request label Aug 20, 2019
This was referenced Aug 20, 2019
Closed
Closed
@Terkwood
Copy link
Owner Author

Terkwood commented Aug 23, 2019 •
edited
Loading

Looks like Sabaki uses preact 8.x. react-modal with preact-compat seems like the fastest path to having something nice. Curious about how much it adds to the JS payload size, tho. And will require some webpack config

@Terkwood Terkwood mentioned this issue Aug 24, 2019
Merged
6 tasks
@Terkwood
Copy link
Owner Author

Try https://material.preactjs.com/

@Terkwood
Copy link
Owner Author

https://github.com/material-components/material-components-web/tree/master/packages/mdc-dialog

@Terkwood Terkwood unpinned this issue Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Multiplayer: Add game venue modal 💬 Terkwood/Sabaki
1 participant
@Terkwood