Crash fix #68
Crash fix #68
Conversation
asynchronize scroll event handler.It make rebuild progress wouldn't happened in viewportBuilder.
|
Thanks for the PR! This PR do fix the issue however I'm concerned that scheduling callbacks frequently with |
Well, that's true.would make widget tree rebuild twice because non-essential refresh But I think crash is more unbearable then some performance overhead |
|
Hello. Could this PR be reconsidered? Almost 100% crashes when using xterm.dart when using application modes like vim or tmux. |
|
Vim use binary instructions to enter application mode.Those instruction can’t convert to utf-8. So, dartssh convert characters failed then throw an exception
For this PR，I remove the utf8 limitation and use binary list to transfer data. This make vim worked.
发自我的iPhone
…------------------ Original ------------------
From: Jooy ***@***.***>
Date: Mon,Jun 27,2022 7:45 AM
To: TerminalStudio/xterm.dart ***@***.***>
Cc: 林翰宇 ***@***.***>, Author ***@***.***>
Subject: Re: [TerminalStudio/xterm.dart] Crash fix (#68)
Hello. Could this PR be re-examined? Almost 100% crashes when using xterm.dart when using application modes like vim or tmux.
Thanks.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
#65
fix crash problem when opening vim or tmux. Use microtask to asynchronous scroll event handler.It make rebuild progress wouldn't happened in viewportBuilder so [rebuild in rebuild progress] wouldn't happen.