Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload to Maven #14

Closed
josephcsible opened this issue Feb 12, 2018 · 10 comments
Closed

Upload to Maven #14

josephcsible opened this issue Feb 12, 2018 · 10 comments

Comments

@josephcsible
Copy link
Contributor

Can you upload this to a Maven repository, to make it easier to include in other mods' development environments?

@TerminatorNL
Copy link
Owner

Honestly? I don't use Maven, and have no idea where to start.
I'd love to help, but I think you need to help me a bit here, I'm a gradle guy 😃

@josephcsible
Copy link
Contributor Author

So the name is a bit misleading. Everyone who uses Maven repositories with Minecraft mods actually uses Gradle, not Maven. It's basically just a place where you upload your compiled mod. Popular free choices are Bintray or Artifactory, but you can host it yourself if you have a public Web server. If you've ever done ./gradlew uploadArchives, the stuff that it puts in your ~/.m2/repository folder is what you'd upload to it. (Or if you use Bintray/Artifactory/etc., just follow their instructions.)

@TerminatorNL
Copy link
Owner

I wonder though, is a maven repository really simpler than just dropping the jar in /libs, and call it a day?

@josephcsible
Copy link
Contributor Author

It lets you use deobfCompile, which means you don't need a dev build with compatible MCP mappings. Also, you don't have to upload big binary files to your git repo if you use gradle to get them.

@TerminatorNL
Copy link
Owner

Ooh that makes alot of sense.

@TerminatorNL
Copy link
Owner

are there any specific functions you want for the developer API?

Right now you can run the profiler, and get the last result if it's available. I also cleaned up the code... ALOT.

@josephcsible
Copy link
Contributor Author

Not really; I just want it to be easily available while I'm testing.

@TerminatorNL
Copy link
Owner

I haven't uploaded it to maven yet. But I made an API available in version 4.1

@TerminatorNL
Copy link
Owner

TerminatorNL commented Sep 16, 2018

I tried to fix this issue in Tiquality.

I cannot get SpongeForge to work in a deobf environment along with a deobfuscated mod. I do not think I can implement this. What I did instead is provide deobfuscated jars in the 'releases' tab, although they're not really useful.

I am actually testing both Tiquality and LagGoggles using a script to install it in an obfuscated environment myself.

If you know of a way to get SpongeForge to work in a deobf environment, I can implement this.

@TerminatorNL
Copy link
Owner

I got SpongeForge to work in a deobf environment, as well as Tiquality. Bintray and Artifactory are both paid solutions. I checked out https://jitpack.io/, but it hangs when compiling the jar. The jar you actually need for development is packaged alongside all releases (DEOBF.). Ivy cannot download this because of some headers GitHub sends before the file. (No clue how all that works, I gave up.)

This is the best alternative I could think of, and people should just drop that in their libs folder.

I'd like to keep everything in a single place (GitHub!). If you know how to add jars from arbitrary URL's into gradle 'compile', please let me know. Closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants