Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potted objects create biome-colored particles when broken, sprinted/fallen on, etc. #2424

Open
muzikbike opened this issue May 30, 2023 · 1 comment
Labels
enhancement Minor new feature, mod compatibility, or QoL improvement.

Comments

@muzikbike
Copy link
Contributor

This is effectively a TFC version of the vanilla bug https://bugs.mojang.com/browse/MC-169697.

Plants in pots will produce particles which are noticeably darker and greener than those of a normal flower pot. This appears to happen for all TFC plants, even those that to my knowledge do not utilize biome coloration at all, such as the athyrium fern:
2023-05-30_21 58 50
2023-05-30_21 58 52

Compare this to a normal vanilla flower pot:
2023-05-30_21 58 55
2023-05-30_21 58 56

This could probably be fixed for potted plants that do not utilize biome coloring at all to have that potential removed. For plants that do use biome coloring, it might be possible to special-case the affected block IDs so that while the block itself uses biome coloring, the particles associated with it do not. Vanilla does this with grass blocks, which is why the dirt particles vanilla grass blocks create are not biome-colored. (See also #2372.)

@muzikbike
Copy link
Contributor Author

While testing this, I noticed that sea ice blocks have blue particles, presumably meaning that their particles have biome coloring applies to them as well. Is this intended?
2023-05-30_21 57 38

@alcatrazEscapee alcatrazEscapee added enhancement Minor new feature, mod compatibility, or QoL improvement. Version: 1.18.x Minecraft 1.18.x labels May 30, 2023
@alcatrazEscapee alcatrazEscapee removed the Version: 1.18.x Minecraft 1.18.x label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Minor new feature, mod compatibility, or QoL improvement.
Projects
None yet
Development

No branches or pull requests

2 participants