Fix GT tools with duplicates in TFC cannot set on the tool racks, and fix GT spare parts melting recipes #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix GT tools with duplicates in TFC cannot set on the tool racks. Since original program will throw ReferenceError. Tested on TFG 0.7.2 with TFC & GTM manually updated to newest version. However, tools appear only in GTM still cannot put on the tool racks. Need further investigation.
Fix spared parts molten product inconsistency between GT and TFC. Now 1 bolt can get 18mB molten metal, 1 screw can get 16mB molten metal, and 1 ring can get 36mB molten metal, suited with GT. Signed-off-by: EliAyase <chemlzh@pku.edu.cn>
chemlzh
changed the title
Change EV coil description Signed-off-by: EliAyase <chemlzh@pku.edu.cn>
Signed-off-by: EliAyase <chemlzh@pku.edu.cn>
|
What you fixed in the tools doesn't really fix anything, because even now there is no error that you wrote about. Only the correction in the file turned out to be useful constants.js , where mining_hammer was replaced with a regular hard_hammer. |
|
And about second part of PR. Fix that and then I merge this |
Exzept1on
reviewed
Apr 27, 2024
Exzept1on
reviewed
Apr 27, 2024
Delete "$" before ToolHelper. This rollback is paired with TFG-Core 0.7.3 Signed-off-by: EliAyase <chemlzh@pku.edu.cn>
Signed-off-by: Dmitry <52341158+Exzept1on@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What for
Fix GT tools with duplicates in TFC cannot set on the tool racks in upcoming TFG 0.7.3. Since original program will throw ReferenceError from KubeJS.
Fix inconsistency in molten metal production from GT spared parts. Now 1 bolt equals to 18mB molten metal, 1 screw equals to 16mB molten metal, and 1 ring equals to 36mB molten metal.
Running platform
Tested on TFG 0.7.2 with TFC & GTM manually updated to newest version.
Some unfinished tasks
However, tools appear only in GTM still cannot put on the tool racks. Need further investigation.