Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMS] Marker popup should show the right content from the Point/Place model #198

Closed
rudokemper opened this issue Mar 7, 2019 · 1 comment
Assignees
Labels
beginner friendly Good for newcomers

Comments

@rudokemper
Copy link
Member

rudokemper commented Mar 7, 2019

Currently, the marker popups show the following content:

[title] (in the popup header)
[region]

It should be the following:

[title] (in the popup header)
[photo]

Region: [region]
Type of place: [type_of_place]

[description]

For region and type of place, if there is no content, then the label does not need to show.

NOTE: this issue is depending on issue 162 being resolved, because some of these data fields still need to be added to the Point/Place model.

@rudokemper rudokemper added beginner friendly Good for newcomers map labels Mar 7, 2019
@rudokemper rudokemper added cms and removed map labels Apr 11, 2019
@rudokemper rudokemper changed the title Marker popup should show the right content from the Point/Place model [UI] Marker popup should show the right content from the Point/Place model Apr 11, 2019
@rudokemper rudokemper removed the cms label Apr 11, 2019
@rudokemper rudokemper added this to the MVP Terrastories 1.0 milestone Apr 11, 2019
@rudokemper
Copy link
Member Author

As per this Ruby by the Bay thread (https://github.com/rubyforgood/terrastories/issues/6), dependent on pending migration updates to the point/place model (current expressed in this issue): #222

@rudokemper rudokemper changed the title [UI] Marker popup should show the right content from the Point/Place model [CMS] Marker popup should show the right content from the Point/Place model Apr 30, 2019
@mirandawang mirandawang self-assigned this Jun 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner friendly Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants