Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Colab notebook enhancements #16

Closed
take2rohit opened this issue Mar 22, 2020 · 2 comments
Closed

Suggestion: Colab notebook enhancements #16

take2rohit opened this issue Mar 22, 2020 · 2 comments

Comments

@take2rohit
Copy link
Contributor

There is a problem of paths in colab.

  1. Colab doesnt know what is ../../bar we need to rather specify Monk/foo/bar
  2. Instead of adding paths like relative + '\' + final + '\' we should rather use os.path.join(relative,final). This is because sometimes it had thrown error even if i entered correct path (that slash caused problem)
  3. Since most of the code base is based on tf 1.x its best to specify %tensorflow_version 1.x at starting of notebook (Since colab will make tf2 default very soon)
@abhi-kumar
Copy link
Contributor

  1. That's a good point. Using os.path.join is a better option than using a string to do the same.
    Please make appropriate changes to notebooks and core code and raise multiple PRs.

For the colab points, I will specify a few things soon.

@abhi-kumar
Copy link
Contributor

Closing the Issue. Solution provided

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants