Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency | Don't include all supported DL Frameworks in requirements.txt #39

Closed
kshitij12345 opened this issue Mar 19, 2020 · 5 comments
Labels
enhancement New feature or request Suggestions

Comments

@kshitij12345
Copy link
Contributor

I don't think it is a good idea to install MXNet, Pytorch, Tensorflow all three for using monk, as I am assuming, most of the people would only be using one of the framework at a given time.

The dependencies become especially heavy for GPU versions (in terms of size) as each library is heavy .

I believe it would be better for user to be able to opt-in the library/libraries of their choice.

@abhi-kumar
Copy link
Contributor

Yes... Very rightly said.

But there are two thing here
a) If you have a look at the core code, certain elements of pytorch are used in mxnet and keras backends. Even when using mxnet, pytorch has to be imported.
b) Once tensorflow 2.0 backend is completely added, we will find a way to reduce the inter-backend dependencies and the issue with installing all the libraries will be resolved.

@kshitij12345
Copy link
Contributor Author

Thanks for the quick response.

I haven't had a look at that part of the code. However, going forward these framework dependencies should be avoided.

Let me know if I can be of any help with the project.

@take2rohit
Copy link
Contributor

I think what we can do is create a separate requirements.txt for each framework wrapper. I have also observed that the requirements.txt is extremely redundant

@abhi-kumar
Copy link
Contributor

Agreed. IT will be taken care in next stable version.

@abhi-kumar abhi-kumar added the enhancement New feature or request label Mar 25, 2020
@abhi-kumar
Copy link
Contributor

Marked as feature enhancement, yet the solution will not be an immediate one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Suggestions
Projects
None yet
Development

No branches or pull requests

3 participants