Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestCentric engine does not support UserSettings #580

Closed
CharliePoole opened this issue May 4, 2020 · 3 comments
Closed

TestCentric engine does not support UserSettings #580

CharliePoole opened this issue May 4, 2020 · 3 comments
Assignees
@CharliePoole
Projects
TestCentric / NUnit Engine Compatibility

Comments

@CharliePoole
Copy link
Contributor

CharliePoole commented May 4, 2020 •
edited

NUnit Compatibility Issue

Category: Services
Visibility: Users
Resolution: Remove from NUnit engine in V4

Description

ISettings interface and UserSettings service have been removed from the TestCentric engine. We discussed removing it from NUnit as well, since it's not really the engine's job to maintain application settings. It would be a breaking change for NUnit, so it's still there. Currently, the TestCentric engine returns null if this interface is requested, as it now does for any unimplemented request.
@CharliePoole CharliePoole created this issue from a note in TestCentric / NUnit Engine Compatibility (API Assembly) May 4, 2020
@ChrisMaddock
Copy link

Agree we should remove in NUnit Engine v4

@CharliePoole
Copy link
Contributor Author

Marked as resolved, pending any further comments from team members. Again, @ChrisMaddock , should we do an issue for V4?

@CharliePoole CharliePoole moved this from Publicly Visible Differences to Resolved in TestCentric / NUnit Engine Compatibility May 30, 2020
@CharliePoole CharliePoole self-assigned this Dec 8, 2020
@CharliePoole CharliePoole mentioned this issue Jan 20, 2021
Closed
@CharliePoole CharliePoole moved this from Resolved - Awaiting Action to In Progress in TestCentric / NUnit Engine Compatibility Feb 9, 2021
@CharliePoole
Copy link
Contributor Author

UserSettings service has been removed from NUnit engine main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CharliePoole CharliePoole

Labels
None yet
Projects
No open projects
TestCentric / NUnit Engine Compatibility
  
Complete
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CharliePoole @ChrisMaddock