Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestCentric engine does not support RecentFiles #582

Closed
CharliePoole opened this issue May 4, 2020 · 6 comments
Closed

TestCentric engine does not support RecentFiles #582

CharliePoole opened this issue May 4, 2020 · 6 comments

Comments

@CharliePoole
Copy link
Contributor

CharliePoole commented May 4, 2020

NUnit Compatibility Issue

Category: Services
Visibility: Users
Resolution: Remove from the NUnit Engine for the 4.0 release

Description

IRecentFiles interface and RecentFiles service have been removed from the TestCentric engine. We discussed removing it from NUnit as well, since it's not really the engine's job to maintain application settings. It would be a breaking change for NUnit, so it's still there. Currently, the TestCentric engine returns null if this interface is requested, as it now does for any unimplemented request.

@ChrisMaddock
Copy link

Agree we should remove in NUnit Engine v4.

@CharliePoole
Copy link
Contributor Author

@ChrisMaddock I edited the description with the resolution.

This is our first resolved issue. Should we create a V4 issue to remove recent files before I close this one?

@CharliePoole
Copy link
Contributor Author

Also, before closing, any other comments from team members?

@mikkelbu
Copy link
Contributor

Not from me. I agree with both of you.

@ChrisMaddock
Copy link

ChrisMaddock commented May 28, 2020

I think this is a good idea. Given this will be a breaking change for the NUnit Engine, I'd like the NUnit issue to properly document the motivation behind the change, and to open it up to the wider community for discussion. It might even make sense to come up with some sort of standard template.

I'll get back to that this weekend - feel free to put something together though, if you can get to this sooner that I can!

@CharliePoole
Copy link
Contributor Author

RecentFiles service now removed from NUnit Engine main

@CharliePoole CharliePoole moved this from In Progress to Complete in TestCentric / NUnit Engine Compatibility Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

3 participants