Java 9: Inaccessable internal APIs in ˋcom.sun.*ˋ

[hastebrot]

Some TestFX functionality might become unavailable with Java 9. We depend on internal JavaFX API for Monocle headless tests, the Glass robot, ... Monocle is an external JAR for desktop system, so this might not cause problems, but on embedded system it might.

https://github.com/TestFX/TestFX/search?q=%22com.sun%22&type=Code

[hastebrot]

Here is some code for Java 9 support in Travis:

• Add Java 9 to the list of available JVM travis-ci/travis-ci#4178 (comment)

Schedule and features for Java 9:

• http://openjdk.java.net/projects/jdk9/

JEP 253: Prepare JavaFX UI Controls & CSS APIs for Modularization

• http://openjdk.java.net/jeps/253

[hastebrot]

Results of review of private JavaFX API for consideration to make public in JDK 9:

• http://mail.openjdk.java.net/pipermail/openjfx-dev/2015-August/017668.html

JEP 253: UI control skins and input mapping discussion

• http://mail.openjdk.java.net/pipermail/openjfx-dev/2015-August/017667.html

[hastebrot]

The first early access builds with the Java Platform Module System were published in September 2015.

The initial version of The State of the Module System, together with JEP 261 and the first early-access builds containing the prototype module system, were published in September 2015.
— http://openjdk.java.net/projects/jigsaw/

Early Access builds of JDK 9 with Project Jigsaw:

• https://jdk9.java.net/jigsaw/

[hastebrot]

Assuming your test program is in the unnamed module (meaning it is run from a jar file or directory of classes on the classpath), the following will work:

java -XaddExports:javafx.graphics/com.sun.glass.ui=ALL-UNNAMED

[hastebrot]

The first Java 9 early access build with integrated Jigsaw+JavaFX is 9 Build 113 [1].

Important milestones in the current schedule:

• 2016/05/26: Feature Complete
• 2017/01/26: Final Release Candidate
• 2017/03/23: General Availability

[1] https://jdk9.java.net/download/

[brcolow]

The jdeps tool shows the cases where we use internal APIs:

testfx-core-4.0.5-alpha.jar -> C:\Program Files\Java\jdk1.8.0_91\jre\lib\ext\jfxrt.jar
   org.testfx.service.adapter.impl.GlassRobotAdapter (testfx-core-4.0.5-alpha.jar)
      -> com.sun.glass.ui.Application                       JDK internal API (jfxrt.jar)
      -> com.sun.glass.ui.Pixels                            JDK internal API (jfxrt.jar)
      -> com.sun.glass.ui.Robot                             JDK internal API (jfxrt.jar)
   org.testfx.service.adapter.impl.JavafxRobotAdapter (testfx-core-4.0.5-alpha.jar)
      -> com.sun.javafx.robot.FXRobot                       JDK internal API (jfxrt.jar)
      -> com.sun.javafx.robot.FXRobotFactory                JDK internal API (jfxrt.jar)
      -> com.sun.javafx.robot.FXRobotImage                  JDK internal API (jfxrt.jar)
   org.testfx.toolkit.impl.ToolkitServiceImpl (testfx-core-4.0.5-alpha.jar)
      -> com.sun.javafx.application.ParametersImpl          JDK internal API (jfxrt.jar)

Warning: JDK internal APIs are unsupported and private to JDK implementation that are
subject to be removed or changed incompatibly and could break your application.
Please modify your code to eliminate dependency on any JDK internal APIs.
For the most recent update on JDK internal API replacements, please check:
https://wiki.openjdk.java.net/display/JDK8/Java+Dependency+Analysis+Tool

[hastebrot]

@brcolow Robot is needed for Monocle. Solution is to use command line parameters for this (we need to use them for Monocle anyway). Functionality of FxRobot can be extracted (approx. five lines of code) [1].

[1] Removal of com.sun.javafx.robot

• http://mail.openjdk.java.net/pipermail/openjfx-dev/2016-May/019127.html

Platform.runLater(() -> {
    Event.fireEvent(scene.getFocusOwner(), keyEvent);
});

[brcolow]

Do you mean something like #355 ?

I was able to pull most things directly out of com.sun.javafx.robot.impl.BaseFxRobot so I am not sure about copyright, etc. But as a proof of concept, is this what you meant? Interestingly only 2 failing tests with this approach.

[tbee]

JFXtras uses TextFX to make sure things keep working. It would be great if I can do the Java 9 migration with running those tests. Is TestFX already running on Java 9?

[brcolow]

TestFX should be working on Java 9 as I removed all uses of the private API. I would speak with more confidence if I could run the test suite but gradle does not currently support jigsaw Java 9 builds. Once gradle support has landed, I will be able to progress on this issue. Brave people who want to try and build without gradle are free to hack about, but I don't have time for that at that moment. I added a Java 9 build to our Travis CI infrastructure which is currently stuck at the gradle step. Seems that full jigsaw support is being tracked in gradle/gradle#719 - which is milestoned for version 4.1 (quite a ways away I think).

[tbee]

Thanks for the response. I'm using Gradle as well for JFXtras, but Maven is already fully Java 9 compatible. I'm considering switching back (maybe polyglot maven :-) ) or to Kobalt

[brcolow]

Indeed - it would honestly not take that much work to also add the equivalent pom.xml's for TestFX...I will look in to maybe doing this in the meanwhile for Java 9 testing.

[hastebrot]

From the Gradle 4.1 release notes (https://docs.gradle.org/4.1/release-notes.html):

This release supports running Gradle on the most recent JDK 9 release (b170+). Read our guide to building Java 9 modules to learn how to produce and consume Java 9 modules with Gradle.

[JordanMartinez]

The guide works, but it's still not as simple as an established plugin. One could use the experimental one, but it's experimental.