Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does TestFX support JavaFX 17 and JDK 17 yet? #745

Closed
yylonly opened this issue Oct 7, 2022 · 6 comments
Closed

Does TestFX support JavaFX 17 and JDK 17 yet? #745

yylonly opened this issue Oct 7, 2022 · 6 comments

Comments

@yylonly
Copy link

yylonly commented Oct 7, 2022

Expected Behavior

Actual Behavior

To get the fastest possible support, create a minimal example
and upload it to GitHub.

Specifications

  • Version:
  • Platform:
@yylonly
Copy link
Author

yylonly commented Oct 31, 2022

Seem this repo is dead, I like to make JavaFX support JDK 17 on Apple Silence, any documentation for the contributor?

@trzimar
Copy link

trzimar commented Nov 1, 2022

@yylonly What isn't working? JDK17+JavaFX19+TestFX in my case works.

@alwins0n
Copy link

alwins0n commented Dec 1, 2022

@trzimar are you using a modularized application? I just tried the junit5 extension (latest alpha) with the following result:

java.lang.IllegalAccessError: class org.testfx.toolkit.impl.ToolkitServiceImpl (in unnamed module @0x163e4e87) cannot access class com.sun.javafx.application.ParametersImpl (in module javafx.graphics) because module javafx.graphics does not export com.sun.javafx.application to unnamed module @0x163e4e87
	org.testfx.toolkit.impl.ToolkitServiceImpl.registerApplicationParameters(ToolkitServiceImpl.java:142)
	org.testfx.toolkit.impl.ToolkitServiceImpl.lambda$setupApplication$6(ToolkitServiceImpl.java:125)
....

@trzimar
Copy link

trzimar commented Dec 1, 2022

@alwins0n non modular and still on JUnit 4

@mvsoder
Copy link
Collaborator

mvsoder commented Jun 21, 2023

@alwins0n This particular issue, with access to ParametersImpl may be resolved by #757. TestFX does support JDK9+, but ParametersImpl is still a protected class in JavaFX and we need to workaround that particular issue. If the upcoming release of TestFX 4 does not resolve the issue, you will still need to add the following to your JVM parameters:

--add-opens=javafx.graphics/com.sun.javafx.application=ALL-UNNAMED

@mvsoder mvsoder closed this as completed Jun 21, 2023
@alwins0n
Copy link

thank you. for what it's worth my requirements were really simple and TestFX goes far beyond that.

For my simple project I am happy with this little fellow of mine: https://github.com/alwins0n/fxtension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants