IconDecoration's gradient property doesn't work anymore

[MeixDev]

Hi!

The package was working fine last time I tested it a few months ago, but it now seems to be incapable of rendering any gradients. It seems the last color used in the gradient is the one used to paint the whole widget.

[TesteurManiak]

I've been able to reproduce this bug with the following test:

Code

void main() {
  group('Goldens Issue #3', () {
    goldenTest(
      "IconDecoration's gradient property doesn't work anymore",
      fileName: 'issue_3',
      widget: GoldenTestGroup(
        children: [
          GoldenTestScenario(
            name: 'with rainbow gradient',
            child: const DecoratedIcon(
              icon: Icon(Icons.all_inbox, size: 50),
              decoration: IconDecoration(
                gradient: rainbowGradient,
              ),
            ),
          ),
          GoldenTestScenario(
            name: 'same rainbow gradient',
            child: const DecoratedIcon(
              icon: Icon(Icons.all_inbox, size: 50),
              decoration: IconDecoration(
                gradient: rainbowGradient,
              ),
            ),
          ),
        ],
      ),
    );
  });
}

Golden

Seems like it is an issue with the gradient's boundaries when creating the shader for the gradient:

if (gradient != null) {
  iconStyle = iconStyle.copyWith(
    foreground: Paint()
      ..shader = gradient.createShader(
        Rect.fromLTWH(0, 0, iconSize, iconSize),
      ),
  );
}

[TesteurManiak]

I've created a custom widget to render Icon with a gradient, it might change a bit the way a gradient is rendered because now its boundaries are correct.

All related test can be found in gradient_test.dart, you should obtain a result similar to this: