Performance++ #97
Merged
Performance++ #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this PR still in progress? |
|
Not necessarily, you can merge it if you want |
3eif
reviewed
Jan 24, 2022
| query = args.slice(1).join(' '); | ||
| source = 'youtube'; | ||
| const platform = args[0].toLowerCase(); | ||
| query = args.slice(1).join(' '); |
There was a problem hiding this comment.
This only works if a platform and a query are provided. It will not work if only a query is provided.
There was a problem hiding this comment.
ahh I see it now, I will fix this in next commit
src/commands/settings/Profile.js
Outdated
| if (!u.bio) bio = 'No bio set. To set your bio type `ear bio <desired bio>`'; | ||
| else bio = u.bio; | ||
|
|
||
| const bio = u ? u.bio : 'No bio set. To set your bio type `ear bio <desired bio>`'; |
There was a problem hiding this comment.
The if statement above already checks if there is a user. This should be changed to u.bio ? u.bio : '...';
There was a problem hiding this comment.
True, didn't think of that. I will change that to nullish coalescing operator
3eif
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes to clean things up a bit