Use proc_macro2::Span::call_site for all quotes
#77
Conversation
fitzgen
force-pushed
the
proc-macro2-nightly-feature-workaround
branch
2 times, most recently
from
3c80b6c
to
733ff4f
Compare
| @@ -0,0 +1,3 @@ | |||
| macro_rules! my_quote { | |||
| ($($t:tt)*) => (quote_spanned!(::proc_macro2::Span::call_site() => $($t)*)) | |||
| } | |||
There was a problem hiding this comment.
If you had a file, you should add the header. But maybe for that, just defining it in lib.rs is OK.
|
Travis should also be updated to test with the problematic feature, no? |
fitzgen
force-pushed
the
proc-macro2-nightly-feature-workaround
branch
from
733ff4f
to
a3409f2
Compare
This avoids breakage when deriving `StructOpt` when `proc_macro2`'s nightly feature is enabled. See dtolnay/proc-macro2#67 for details.
fitzgen
force-pushed
the
proc-macro2-nightly-feature-workaround
branch
from
a3409f2
to
a028c45
Compare
|
Added
|
|
FWIW This isn't so much a workaround as necessary today based on today's hygiene implementation, otherwise fixing this without changing span information would require far more intrusive changes to structopt which'd probably want to be delated for later :) |
|
OK. I tried to look at it, but didn't really understand why it doesn't find std. If you know of any doc on that or any similar problem fixed in another project, I would be interested to look at it for my own curiosity. |
|
v0.2.5 published |
|
@TeXitoi rust-lang/rust#45934 may have a bit more of a writeup if you're interested to dig more! |
|
Thanks |
This avoids breakage when deriving
StructOptwhenproc_macro2's nightly feature is enabled. See dtolnay/proc-macro2#67 for details.cc @alexcrichton