Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTable crash #3470

Closed
willmcgugan opened this issue Oct 5, 2023 · 3 comments · Fixed by #3487
Closed

DataTable crash #3470

willmcgugan opened this issue Oct 5, 2023 · 3 comments · Fixed by #3487
Assignees
@darrenburns

Comments

@willmcgugan
Copy link
Collaborator

"When updating a cell in DataTable with update_width=True, then remove the row, a crash will happen when on_idle run."

From the following PR:

#3211
@rodrigogiraoserrao
Copy link
Contributor

In the linked PR you say we're going with a different approach than the one in the PR. Have you thought of a specific alternative?

@willmcgugan
Copy link
Collaborator Author

The approach suggested by Darren in the linked PR.

@darrenburns darrenburns self-assigned this Oct 9, 2023
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

@rodrigogiraoserrao rodrigogiraoserrao linked a pull request Oct 9, 2023 that will close this issue
Fix DataTable crash when removing and updating cell at the same time #3487
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darrenburns darrenburns

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix DataTable crash when removing and updating cell at the same time Textualize/textual
3 participants
@willmcgugan @rodrigogiraoserrao @darrenburns