RadioButton still selectable by keyboard when disabled

[geoff-va]

It appears that when a RadioButton is disabled, click events no longer respond as expected, but you can still navigate to it with the keyboard and select it with space or enter.

from textual.app import App, ComposeResult
from textual.widgets import RadioButton, RadioSet, Static


class Test(App):
    DEFAULT_CSS = """
    RadioButton:disabled {
        color: red;
    }
    """

    def compose(self) -> ComposeResult:
        with RadioSet():
            yield RadioButton("Enabled 1")
            yield RadioButton("Disabled 2", disabled=True)
            yield RadioButton("Disabled 3", disabled=True)
        yield Static("Selected:", id="selected")

    def on_radio_set_changed(self, radio_set: RadioSet.Changed) -> None:
        self.query_one("#selected").update(f"Selected: {radio_set.pressed.label}")


if __name__ == "__main__":
    app = Test()
    app.run()

Textual Diagnostics

Versions

Name	Value
Textual	0.44.1
Rich	13.7.0

Python

Name	Value
Version	3.8.10
Implementation	CPython
Compiler	Clang 12.0.5 (clang-1205.0.22.9)
Executable	/Users/geoff/Documents/projects/test/venv/bin/python

Operating System

Name	Value
System	Darwin
Release	22.5.0
Version	Darwin Kernel Version 22.5.0: Thu Jun 8 22:22:19 PDT 2023; root:xnu-8796.121.3~7/RELEASE_ARM64_T8103

Terminal

Name	Value
Terminal Application	vscode (1.85.0)
TERM	xterm-256color
COLORTERM	truecolor
FORCE_COLOR	Not set
NO_COLOR	Not set

Rich Console options

Name	Value
size	width=158, height=40
legacy_windows	False
min_width	1
max_width	158
is_terminal	True
encoding	utf-8
max_height	40
justify	None
overflow	None
no_wrap	False
highlight	None
markup	None
height	None

[davep]

Good spot: for clarification, this looks to be a RadioSet bug, not a RadioButton bug.

[willmcgugan]

This may impact other widgets where you can press a key to select. Suggest we also check other widgets.

[github-actions]

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

[rodrigogiraoserrao]

This may impact other widgets where you can press a key to select. Suggest we also check other widgets.

You were right.

• SelectionList and OptionList allow highlighting disabled items (with keyboard & mouse) but don't allow selection.
• ListView allows highlighting with keyboard but not with mouse (and doesn't allow selection).
• As of PR 3872, RadioSet doesn't allow neither navigation nor selection.

I feel like we should disable navigation everywhere and instead Up / Down should only go through enabled children.

[willmcgugan]

Agree, please adds that to ToDo