Add support for specifying the screenshot location and filename #4181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will work in conjunction with TEXTUAL_SCREENSHOT, most of the time.
rodrigogiraoserrao
approved these changes
Feb 19, 2024
Comment on lines
12
to
+15
| - Added support for environment variable `TEXTUAL_ANIMATIONS` to control what animations Textual displays https://github.com/Textualize/textual/pull/4062 | ||
| - Add attribute `App.animation_level` to control whether animations on that app run or not https://github.com/Textualize/textual/pull/4062 | ||
| - Added support for a `TEXTUAL_SCREENSHOT_LOCATION` environment variable to specify the location of an automated screenshot https://github.com/Textualize/textual/pull/4181/ | ||
| - Added support for a `TEXTUAL_SCREENSHOT_FILENAME` environment variable to specify the filename of an automated screenshot https://github.com/Textualize/textual/pull/4181/ |
There was a problem hiding this comment.
0.52.0 will be “The Env Vars release”
willmcgugan
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the Textual side of #3795; adding two new environment variables that work alongside
TEXTUAL_SCREENSHOT:TEXTUAL_SCREENSHOT_LOCATION-- the directory where the screenshot should be saved.TEXTUAL_SCREENSHOT_FILENAME-- the filename to give the screenshot.With this change you can do something like this:
which will save a screenshot called
foo.svgin/Users/davepafter 1 second.This change serves an incoming PR to
textual-dev.