New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ASRangeController] Clarifications on how working ranges are expected to function (iOS 7) #110
Comments
From @appleguy on November 12, 2015 18:41 @hashemp206 hmm, that definitely shouldn't be the case. Thanks for reporting it. Can you give more information on your setup? What are the values for rangeTuningParameters? What do you have onscreen; just a vertical collection view, or does it also contain horizontally scrolling elements? Note this is the expected behavior:
|
From @hashemp206 on November 12, 2015 19:42 here is the sample app: scroll smoothly to next item on iPhone 4 you see next cells backgroundImageNode had not layouted! and immediately you see image loaded with a popcorn effect. but on later iOS version pop corn effect won't visible! |
From @appleguy on November 14, 2015 2:44 Thanks a lot for the test app! Going to check it out now. |
From @appleguy on November 14, 2015 2:47 @hashemp206 could you be more precise about the "layout" methods you're talking about? Let me know kinda step-by-step exactly what you're comparing. Are you looking at when -layout is called? or is it -layoutSpecThatFits? or something else? |
From @appleguy on November 14, 2015 5:27 @hashemp206 I got your app running on an iPhone 4 with iOS 7. I don't see any obvious issues...if you swipe fast enough, you can get ahead of the image decoding, and briefly see the blue background. However, if you scroll slowly, I don't see any of these blue reveals. This doesn't appear to be any issue with layout not being performed, simply rendering catching up. You can use .backgroundColor or other features like .placeholderImage to customize the appearance of the image area before the decoding is finished. Please let me know ASAP if you have any other input on the symptom you're seeing. A video would be a good option! |
From @appleguy on November 14, 2015 5:30 @hashemp206 oh man, I just found that you had closed this task...I wonder why?! facebookarchive/AsyncDisplayKit#769 That is definitely still an issue, and is a known issue. I can reproduce THAT problem if I scroll left and right between "one" and "five" - but it works fine if I scroll incrementally through 1, 2, 3 ... 5, 1, 2 without any flashes. Since the issue with a cyclic view is already known, can you provide more clear descriptions of what the problem is that doesn't involve the cyclic part of the view? If we disabled cyclic scrolling, that would be the best way to test it. |
From @hashemp206 on November 14, 2015 13:32 @appleguy thanks for feedback, if Im right in iOS 7 subsequent cells won't load immediately but on iOS 8 and above works well. see the generated logs. in this video after application launched and after 6 seconds later I scroll to next cell! as you see cell is not loaded! I'm using ASyncDisplayKit a lot in my app and I really need circular scrolling in some of my custom controls! the only hack I found to prevent flashing when backwarding is preloading all cells in advanced! |
From @hashemp206 on November 12, 2015 8:12
as it supposed to be pre layouting cells in ASCollectionView works well in iOS 8 and 9 and cells gets layout in advance. but today I test it on my iPhone 4 with iOS 7. cells layout method doesn't called, until I scroll to that cell!
any idea?
Copied from original issue: facebookarchive/AsyncDisplayKit#840
The text was updated successfully, but these errors were encountered: