[ASDataController] Fix a crash in table view caused by executing an empty change set during layoutSubviews #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing layoutSubviews - Previously, when a change set is empty, `ASDataController` forwards the change set to its delegate right away, without dispatching to its editing queue and then back to main. - This behaviour can potentially cause bad internal states in UITableView which trigger a crash reported in TextureGroup#83. - Fix by still reusing the existing pending map, because the data source's state has not changed, but go through the editing queue and main queue tunnel.
Adlai-Holler
approved these changes
Jul 5, 2017
There was a problem hiding this comment.
Beautiful! I know @rewandy has been patiently waiting for a fix for this, and I love the unity of the code paths in the new approach.
|
We can confirm this addresses our issue! Thanks so much for tackling this - we can finally get with the times and update to Texture! |
|
You're welcome, @rewandy! We've just found out that we got a number of crash reports in the Pinterest app with the same stack trace. It would be super hard for us to debug it without your details GitHub issue and test project. So thank you! |
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
…mpty change set during layoutSubviews (TextureGroup#416) * Fix a crash in table view caused by executing an empty change set during layoutSubviews - Previously, when a change set is empty, `ASDataController` forwards the change set to its delegate right away, without dispatching to its editing queue and then back to main. - This behaviour can potentially cause bad internal states in UITableView which trigger a crash reported in TextureGroup#83. - Fix by still reusing the existing pending map, because the data source's state has not changed, but go through the editing queue and main queue tunnel. * Update CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASDataControllerforwards the change set to its delegate right away, without dispatching to its editing queue and then back to main.Fixes #83.