Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Simplify Dungeon Block Item Model Code #2054

Closed
3 tasks done
Builderdog841 opened this issue Mar 9, 2024 · 1 comment
Closed
3 tasks done

Feature Request: Simplify Dungeon Block Item Model Code #2054

Builderdog841 opened this issue Mar 9, 2024 · 1 comment
Assignees
@bconlon1
Labels
priority/low This issue is of low priority to fix. type/request The issue is a feature or change request and does not fit into the other types.

Comments

@Builderdog841
Copy link

What Feature Types Apply to This Request?

System

Other Type

No response

Is This an Enhancement to a Preexisting Feature?

  • I confirm this request is an enhancement to a feature already in The Aether.

What Is Your Feature Request?

Currently the entire Item Model gets generated for each individual block again. By making a template model for the Dungeon Block Model and then have it be the parent model of the Item Model, you would simplify the code a lot

Why Should It Be in the Mod?

It improves code

Does This Feature Improve Compatibility With Another Mod?

No response

Please Read and Confirm the Following

  • I have confirmed this feature is either in the original Aether mod, or improves parity between The Aether and Minecraft or other mods.
  • I have confirmed this suggestion is unique and has not been suggested already.
@Builderdog841 Builderdog841 added the type/request The issue is a feature or change request and does not fit into the other types. label Mar 9, 2024
@bconlon1 bconlon1 added this to the 1.5.0 Update milestone Mar 18, 2024
@bconlon1 bconlon1 added the priority/low This issue is of low priority to fix. label Apr 2, 2024
@bconlon1 bconlon1 self-assigned this Apr 2, 2024
@bconlon1 bconlon1 removed this from the 1.5.0 Update milestone May 21, 2024
@bconlon1
Copy link
Contributor

Probably not going to bother with this since it's so minor of a code change.

@bconlon1 bconlon1 closed this as not planned Won't fix, can't repro, duplicate, stale May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bconlon1 bconlon1

Labels
priority/low This issue is of low priority to fix. type/request The issue is a feature or change request and does not fit into the other types.
Projects
The Aether
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bconlon1 @Builderdog841