Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heals and Buffs attempt to target selected neutral mob both out and in combat #257

Closed
OrthoTemplar opened this issue Apr 1, 2022 · 4 comments
Labels
bug Something isn't working spell Issues related with spells

Comments

@OrthoTemplar
Copy link

Description
If you have a neutral (yellow) mob selected and try to heal or buff , it tries to target the mob and does nothing at end of cast

Steps to reproduce

  1. Select neutral mob that is not a critter - Ex: Mountain Boar
  2. Cast buff or heal - Ex: Holy Light , Seal of Might (maybe Spell Phantom dmg when getting healed from food #636 , can't find source)
  3. Nothing happens and mana is spent

Expected behavior
Have cursor change to select target for cast

@OrthoTemplar OrthoTemplar added the bug Something isn't working label Apr 1, 2022
@Fluglow
Copy link
Member

Fluglow commented Apr 1, 2022

Caused by the client considering neutral targets assistable and EffectTargets considering valid targets to only be unattackable ones. target_is_friendly in EffectTargets.get_simple_targets should account for neutral targets too (target_is_assistable?), assuming the client's behavior is intended.

@Daribon
Copy link
Contributor

Daribon commented Jun 18, 2022

I cannot reproduce this bug. I was able to target Mountain Boar and buff myself with Frost Armor
Tried with paladin using Holy Light and Seal of Might and I was able to use both when targeting Mountain Boar.

@OrthoTemplar
Copy link
Author

OrthoTemplar commented Jun 18, 2022

It's quite old and was maybe fixed?

@Yushe Yushe added the spell Issues related with spells label Aug 3, 2022
@Fluglow
Copy link
Member

Fluglow commented Aug 10, 2022

Closing since this bug can't be reproduced anymore.

@Fluglow Fluglow closed this as completed Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working spell Issues related with spells
Projects
None yet
Development

No branches or pull requests

4 participants