Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event for when balance changes #1

Closed
The-Fireplace opened this issue Nov 23, 2019 · 3 comments
Closed

Event for when balance changes #1

The-Fireplace opened this issue Nov 23, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@The-Fireplace
Copy link
Member

@AustereTony-MCMods:

MC version: 1.12.2

Hello.

Grand Economy is a great option for implementing an economy for the server, and support for third-party platforms (like Sponge) is a great bonus.

I use Grand Economy to integrate third-party economies into my project (Oxygen). In my opinion, there is not enough opportunity to track a change in a player’s balance when this change occurs through Grand Economy (eg. chat commands). Could you add an event to track the player’s balance update and fire it when the balance changes inside the Grand Economy?

I need this to be able to synchronize the player’s balance with the client, if it was changed using the Grand Economy commands. At the moment, I have to use ASM transformers to implement hooks in your methods in order to track changes, which is not very convenient and not safe in case of Grand Economy update. Hooks with position: https://github.com/AustereTony-MCMods/Oxygen-Currency-Providers/blob/grand-economy/src/main/java/austeretony/oxygen_cp_ge/common/core/CurrencyProviderHooks.java

If you can add an event and provide the player's UUID, the old and new balance, it would be great.

Thank you.

@The-Fireplace The-Fireplace added the enhancement New feature or request label Nov 23, 2019
@The-Fireplace
Copy link
Member Author

Thoughts on this?
116fdb2

@AustereTony-MCMods
Copy link

Fine! I updated the provider and tested it with Grand Economy 1.3.1, the balance change event fulfills its function, thank you. When new version of Grand Economy will be released?

@The-Fireplace
Copy link
Member Author

It is currently only available to Patrons, and will be posted to CurseForge on December 8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants