generated from MultiverseLearningProducts/inventory-app
-
Notifications
You must be signed in to change notification settings - Fork 1
/
cory-code-review-1.txt
29 lines (23 loc) · 1.41 KB
/
cory-code-review-1.txt
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
Hey Syntax Slingers! :) Popping in to give some initial feedback on the codebase!
Readability
------------------------------------------------------------------------------------------
[yes] New code is syntactic - everything clearly named (files, objects, functions, variables)
[yes] Clear, concise comments that describes why code was included rather than what it does
[yes] No redundant comments
Security
------------------------------------------------------------------------------------------
[n/a] All secret information is stored securely (environmental variables, github secrets)
[n/a] User information protected appropriately (encryption, auth)
Stability
------------------------------------------------------------------------------------------
[yes!] Errors are handled where necessary (try/catch blocks, console errors, status codes)
[n/a] Appropriate test coverage and reporting (unit, end-to-end, accessibility)
"First route looks great!! Super clean, keep up the great work."
"Looking forward to seeing some awesome unit testing!"
Architecture
------------------------------------------------------------------------------------------
[yes] Code uses encapsulation and modularization to achieve separation of concerns
[yes] File tree is organized and navigable
Reusability
------------------------------------------------------------------------------------------
[yes] Code uses reusable components, functions, and services