Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gather code coverage #103

Merged
merged 30 commits into from Oct 27, 2020
Merged

Conversation

Parowicz
Copy link
Contributor

Welcome to Dart community

@cclauss i've fixed your pull request according to #100
Right now I'm saving coverage in *.lcov format. You have ideas how to proceed?

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Dart files are placed inside an existing directory.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Co-authored-by: Christian Clauss <cclauss@me.com>
@cclauss
Copy link
Member

cclauss commented Oct 16, 2020

LOL!! --pretty-print spits out way too much information!! I was just looking for a percent of test coverage for each file.

  • a.dart 20%
  • b.dart 90%
  • c.dart 0%

@Parowicz
Copy link
Contributor Author

@cclauss lcov -l coverage.lcov format will do?

@cclauss
Copy link
Member

cclauss commented Oct 16, 2020

Does this mean that every dart file has tests and there are no dart files that have 0% code coverage?

@Parowicz
Copy link
Contributor Author

dart test executor is executing all main function and when examples run they mostly cover whole file.
For real test coverage we would need to put all tests in separate directory - now it's test coverage + examples coverage.

@cclauss
Copy link
Member

cclauss commented Oct 16, 2020

Cool. I think this is good to go.

@Parowicz Parowicz marked this pull request as ready for review October 16, 2020 17:32
@mohammadreza490 mohammadreza490 merged commit b4a844b into TheAlgorithms:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants