Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of singly linked list in Dart #139

Closed
wants to merge 2 commits into from
Closed

Implementation of singly linked list in Dart #139

wants to merge 2 commits into from

Conversation

nandikajain
Copy link

@nandikajain nandikajain commented Oct 22, 2020

Welcome to Dart community

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Dart files are placed inside an existing directory.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@Parowicz
Copy link
Contributor

Hello! Looks like we already have Linked List implementation. Could you point differences between already existing one and your proposal?

You could also reuse test cases from existing implementation.

@nandikajain
Copy link
Author

Oh!
Since it was not in the Linked List folder, I did not notice. The linked List folder only had one code for circular linked list.
I guess it should be moved in the linked list folder then!

@nandikajain
Copy link
Author

Will this PR be considered under Hacktoberfest?

@Parowicz
Copy link
Contributor

Well, only if merged.

@nandikajain
Copy link
Author

Okay, I will add the implementation of Doubly Linked List, will it be considered?

@Parowicz
Copy link
Contributor

Yea, we don't have any implementation of doubly linked list yet.
List of implemented algorithms can be found in DIRECTORY.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants