Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Go to 1.18 for generics implementation #478

Closed
paul-leydier opened this issue Mar 23, 2022 · 2 comments
Closed

Bump Go to 1.18 for generics implementation #478

paul-leydier opened this issue Mar 23, 2022 · 2 comments
Labels
dont-close enhancement help wanted progress Solving this issue is in progress.

Comments

@paul-leydier
Copy link
Contributor

Hi everyone!

I was wondering, what is your position regarding the implementation of algorithms using generics on this repo?

Are you waiting a bit longer before upgrading to go 1.18, or should we do it now so that we can already start getting hands-on experience with generics?

If so, I recommend using the constraints defined in golang.org/x/exp/constraints as standard constraints!

@tjgurwara99
Copy link
Member

tjgurwara99 commented Mar 23, 2022

I'm more than happy to bump the version now and I was thinking to start it but we need to do a bit of cleanup of the repository structure before we do that. Currently its all over the place 😓

I'll be opening a series of PR's to make these changes in an incremental (and traceable) way – will keep posting updates on this issue.

On the topic of constraints, I would like to use it but it's an experimental package and I would rather just create our own generic interfaces from ground up until we get some more data - that package was supposed to be just constraints instead of golang.org/x/exp/constraints but some members of the community didn't like this package for various reasons (mostly because of naming).

@tjgurwara99
Copy link
Member

closed in #483

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dont-close enhancement help wanted progress Solving this issue is in progress.
Projects
None yet
Development

No branches or pull requests

3 participants