Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTHER] updating sort algorithm parameters to Generic type <T> #3767

Closed
Tabbygray opened this issue Nov 18, 2022 · 5 comments
Closed

[OTHER] updating sort algorithm parameters to Generic type <T> #3767

Tabbygray opened this issue Nov 18, 2022 · 5 comments
Assignees
Labels

Comments

@Tabbygray
Copy link
Contributor

What would you like to share?

in [sorts] package, algorithms offer .sort() function.
most of them has input parameter as generic type Comparable, but some of them supports int[ ] only.

※algorithms that sort int[ ] only = [BinaryInsertionSort, BucketSort, DNFSort, OddEvenSort, PigeonHoleSort, RadixSort]
exception : beadsort (algorithm cannot sort negative int / String sort)

how do you think about updating algorithm's parameter type to Generic type ?

Additional information

No response

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 19, 2022
@siriak
Copy link
Member

siriak commented Dec 20, 2022

I think we should do that because comparability is everything they need to work

@github-actions github-actions bot removed the stale label Dec 21, 2022
@Regyl
Copy link

Regyl commented Jan 15, 2023

@siriak I'd like to do that, could you assign to me?

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 16, 2023
@github-actions
Copy link

Please reopen this issue once you add more information and updates here. If this is not the case and you need some help, feel free to seek help from our Gitter or ping one of the reviewers. Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants