Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTHER] Wrong assignment #4331

Closed
lukasb1b opened this issue Aug 25, 2023 · 3 comments
Closed

[OTHER] Wrong assignment #4331

lukasb1b opened this issue Aug 25, 2023 · 3 comments
Labels

Comments

@lukasb1b
Copy link
Contributor

What would you like to share?

The files src/main/java/com/thealgorithms/maths/FindMaxRecursion.java , src/main/java/com/thealgorithms/maths/FindMax.java , src/main/java/com/thealgorithms/maths/FindMin.java and src/main/java/com/thealgorithms/maths/FindMinRecursion.java are in the math folder. But they are searches so shouldn´t those be in the searches folder?

Additional information

No response

@lukasb1b lukasb1b added the awaiting triage Awaiting triage from a maintainer label Aug 25, 2023
@azertl
Copy link

azertl commented Aug 25, 2023

I understand that search algorithms are dedicated to the search of a specific pattern in a data set, eventually not finding it.
In that aspect, algorithms in the search package are search algorithms... well at least for those that I have opened before commenting your issue.
On the other side, the FindXXX algorithms are rather supposed to extract a specific information on the set of data that you have. It is simple math but in my opinion, it is still math, not search.
Furthermore, I like the fact that algorithms are categorized the same way in different languages. At least, in Python, they are also considered as search algorithms.

@siriak
Copy link
Member

siriak commented Aug 26, 2023

Thanks for bringing this up! I certainly see the problem here. Even in searches folder there are searches in a sorted array, in a graph, and other. It's not clear-cut how to organize them, and, as @azertl has already stated, there are also arguments in favor of having some of them in maths. Besides, they are all pulled in https://the-algorithms.com/ website, so moving them would break the website categorization.

@siriak siriak removed the awaiting triage Awaiting triage from a maintainer label Aug 26, 2023
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants