Fixes The Bug In Radix Tree. Issue #11316 #11385
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
covid-in
changed the title
for more information, see https://pre-commit.ci
Based on ruff Recommendations
- Removed WhiteSpaces
- Moved the Import to beginning
- Replaced assertTrue with regular assert
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
algorithms-keeper
bot
removed
the
tests are failing
|
Hey @spazm. Can you please review this PR. Radix Tree had a bug. And Excuse me for the commit mess. Ruff gave me some problems |
imSanko
approved these changes
Apr 26, 2024
cclauss
reviewed
May 1, 2024
| @@ -1,3 +1,5 @@ | |||
| import unittest | |||
There was a problem hiding this comment.
We (and the majority of the Python community) use pytest instead of unittest so all this boilerplate is not needed.
As discussed in CONTRIBUTING.md, changing both code and tests in a single pull request makes code review quite difficult.
Can you please create a separate simple pull request that adds a test that proves that word = "" fails?
Once that is proven, we can determine how to proceed with this pull request.
cclauss
reviewed
May 1, 2024
|
|
||
| class TestRadixNode(unittest.TestCase): |
There was a problem hiding this comment.
This boilerplate adds unnecessary complexity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Fixes #11316 .
There is a bug in the code which doesn't handle the edge case when the insertion of empty string is done.
Checklist: