Null safety #211
Null safety #211
Conversation
There was a problem hiding this comment.
Thanks @lielb100 for making this contribution. You have done a great job. Let me know if you are done with all required changes. Once you done I'll review the PR and let you know if something still needs to be change.
|
Sorry it talk long, but it's done and ready to be reviewd, I'd be happy to help with further devolopment of the app.
|
|
|
||
| NotificationModel.fromJson(String tweetId, Map<dynamic, dynamic> map) { | ||
| this.id = tweetId; | ||
| id = tweetId; | ||
| final data = json.decode(json.encode(map["data"])) as Map<String, dynamic>; |
There was a problem hiding this comment.
Getting below error during app start.
Unhandled Exception: type 'Null' is not a subtype of type 'Map<String, dynamic>' in type cast
| cprint(e, errorIn: "On onMessageOpenedApp"); | ||
| } | ||
| FirebaseMessaging.onMessageOpenedApp.listen((RemoteMessage? event) { | ||
| if (event != null) { |
There was a problem hiding this comment.
Have of add null check condition for event.data. There are some cases where event.data occured to be null value
There was a problem hiding this comment.
event.data is a non nullable String, I don't think it's possible for it to be null.
| await remoteConfig.fetchAndActivate(); | ||
| // await remoteConfig. | ||
| var data = remoteConfig.getString('FcmServerKey'); | ||
| if (data != null && data.isNotEmpty) { | ||
| if (data.isNotEmpty) { |
There was a problem hiding this comment.
Add data null check condition. If FcmServerKey is not available in firebase remote config then it'll retun null value.
There was a problem hiding this comment.
Data is a non nullable String, I don't think it's possible for it to be null.
| await remoteConfig.fetchAndActivate(); | ||
| // await remoteConfig.activateFetched(); | ||
| var data = remoteConfig.getString('appVersion'); | ||
| if (data != null && data.isNotEmpty) { | ||
| if (data.isNotEmpty) { |
There was a problem hiding this comment.
Add null check condition for data
There was a problem hiding this comment.
Data is a non nullable String, I don't think it's possible for it to be null.
Upgrade to Flutter SDK 2.12.0 sound null safety
I spent a lot of time and made the whole repo null safe, to make it more modern and future-proof.
Also I linted all the code with these analysis rules:
Suggesting to add a new branch for null_safety, and merge it when it is 100% stable.
Packages
flutter_link_previewdidn't have a null safe version so I replaced itflutter_link_previewernew link preview packageflutter_chat_typesforPreviewDatatypetranslatorfor tweet translation