Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daemon searches home directory as well as specified directory #305

Closed
colinl opened this issue Feb 20, 2020 · 2 comments
Closed

Daemon searches home directory as well as specified directory #305

colinl opened this issue Feb 20, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@colinl
Copy link

colinl commented Feb 20, 2020

Describe the bug
The daemon searches /home/me as well as the directory specified in the destination directory

Expected behavior
It should only search the specified directory

To Reproduce
Steps to reproduce the behavior:

  1. Enter an existing directory in the copy to field in the GUI
  2. Enable the daemon
  3. Monitor the log

System, software and AppImage information
Ubuntu 19.10

AppImageLauncher version installed:
2.1.1-travis931~f6d5926+bionic from release page

Syslog extract with /home/me/apps/appimages specified in the dialog

Feb 20 09:18:37 tigger systemd[3834]: Started AppImageLauncher daemon.
Feb 20 09:18:37 tigger appimagelauncherd[14589]: Searching for existing AppImages
Feb 20 09:18:37 tigger appimagelauncherd[14589]: Searching directory: /home/me
Feb 20 09:18:37 tigger appimagelauncherd[14589]: Searching directory: /home/me/apps/appimages
Feb 20 09:18:37 tigger appimagelauncherd[14589]: Found AppImage: /home/me/apps/appimages/Ultimaker_Cura-4.4.1_2baf12a636cb3a72dbbdd1fb57afe251.AppImage
Feb 20 09:18:37 tigger appimagelauncherd[14589]: AppImage integrated already, skipping
Feb 20 09:18:37 tigger appimagelauncherd[14589]: Watching directories: /home/me /home/me/apps/appimages
Feb 20 09:19:07 tigger appimagelauncherd[14589]: Directories to watch disappeared, unintegrating AppImages formerly found in there
@colinl colinl added bug Something isn't working needs verification Description of the issue needs to be verified by the team labels Feb 20, 2020
@TheAssassin TheAssassin removed the needs verification Description of the issue needs to be verified by the team label Feb 20, 2020
@TheAssassin
Copy link
Owner

Observed this behavior in an Ubuntu VM, too. Not sure what causes this.

@TheAssassin
Copy link
Owner

Note for self: Qt's string splitting is weird on empty strings. It produces a list with an empty string as the only entry. These empty strings are, for some reason, considered to refer to the home directory.

I ignore all empty strings now, which also fixes this problem. Furthermore, non-absolute paths which also don't contain a ~ (which would be expanded to the home directory by my code) are ignored now, too, preventing further such weirdnesses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants