Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fully static runtimes #585

Open
2 tasks done
TheAssassin opened this issue Jul 10, 2023 · 2 comments
Open
2 tasks done

Support fully static runtimes #585

TheAssassin opened this issue Jul 10, 2023 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@TheAssassin
Copy link
Owner

Pre-submit checks

  • I checked for similar issues beforehand, but could not find any. I could not add my proposal to any existing issue.
  • I am going to take the time to to fill in all the required details. I know that the bug report will be dismissed otherwise.

Feature description

See AppImage/AppImageSpec#38 for all the details.

Proposed solution

Once an AppImage spec type 2.1 is released, we can reliably detect that and know that $TARGET_APPIMAGE is available as a feature. We then do not need to use $LD_PRELOAD any more at all.

Alternative solutions you considered

No response

Additional context

No response

@TheAssassin TheAssassin added the enhancement New feature or request label Jul 10, 2023
@TheAssassin TheAssassin added this to the version-3.0 milestone Jul 10, 2023
@probonopd
Copy link
Contributor

Once an AppImage spec type 2.1 is released, we can reliably detect that and know that $TARGET_APPIMAGE is available

Would running something like strings ... | head ... | grep "TARGET_APPIMAGE" be a reasonable detection, so that it would work without the need for a type 2.1?

@TheAssassin
Copy link
Owner Author

We can do it properly. Why resort on such a hack?

Not to mention that this additional version marker is a great test run for the already-WIP type 3, in which the magic bytes will be moved in a similar way to another location, too.

I'm open to alternative suggestions, but please let us use the spec issue for coordination.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants