Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip the header #3

Closed
TheAwiteb opened this issue Feb 26, 2023 · 1 comment · Fixed by #4
Closed

Strip the header #3

TheAwiteb opened this issue Feb 26, 2023 · 1 comment · Fixed by #4
Assignees
Labels
enhancement New feature or request

Comments

@TheAwiteb
Copy link
Owner

Our wave file is two section, the first section is the wave header (44 bytes) and second section is the original file data. And the decoding process taking long than encoding (x2 benchmarks). I think is better to strip it and rewrite the data to the output file. @Amjad50 what do you think?

My prototype of strip way with 2.7 GB

Executed in 4.79 secs fish external
usr time 3.17 secs 550.00 micros 3.17 secs
sys time 1.54 secs 353.00 micros 1.54 secs

Current way with 2.7 GB

Executed in 12.62 secs fish external
usr time 11.04 secs 472.00 micros 11.04 secs
sys time 1.54 secs 279.00 micros 1.54 secs

@TheAwiteb TheAwiteb added the enhancement New feature or request label Feb 26, 2023
@TheAwiteb TheAwiteb self-assigned this Feb 26, 2023
@Amjad50
Copy link
Contributor

Amjad50 commented Feb 26, 2023

Nice performance boost

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants