Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add the ability to go full width and dock to the editor #59

Open
mattrcullum opened this issue Mar 19, 2024 · 7 comments

Comments

@mattrcullum
Copy link

The emacs/vim which key plugins both take up the full width of the screen and are docked in the editor whereas idea-which-key seems to always have right margin and is not docked within the editor.

Would there be any interest in a PR that adds the ability to make idea-which-key behave more similarly to the emacs/vim variants?

For reference, here's the way emacs behaves
CleanShot 2024-03-19 at 15 07 38@2x

And here's idea which key
CleanShot 2024-03-19 at 15 10 03@2x

I know it's a relatively small thing but aestethics really matter to me and I would be happy to do the work if there's interest.

@mattrcullum
Copy link
Author

With some basic modifications in PopupConfig.kt I was able to make the baloon popup take the full width of the frame. If this is something the community is interested in I'd be happy to expand on it based on everyone's feedback.

CleanShot 2024-03-19 at 17 09 22@2x

@TheBlob42
Copy link
Owner

That looks really good 👍
I believe the only reason I did not go for the full width initially, was that I could not find a way to do it 😅
I would be interested in a PR for your changes. I personally don't see any reason to not make this the default look.

@Inmoresentum
Copy link

This seems a nice change :)

@qrzychu
Copy link

qrzychu commented Mar 20, 2024

I would actually like something opposite :)

I am on ultrawide monitor and popup does not show up over the correct tab:
image

as you can see, I was in the file on the right, and seeing the popup all the way on the left is not that heplfull
also, I don't have that many commands in my config, so I don't really need the plugin :)

personally, I think show up centered at least, and with less space between commands if there are few.

Is there a way I could increase the font size in the popup?

@TheBlob42
Copy link
Owner

Maybe we can make this configurable to some extend 🤔

Is there a way I could increase the font size in the popup?

You can adjust the font size as well as some other appearance related parameters. See the README here

@mattrcullum
Copy link
Author

mattrcullum commented Apr 1, 2024

Sorry for the delay in responding to this, I've been very busy with work. On that note - I've been using my fork of this for the past 2 weeks with 0 issues.

@qrzychu I took a look at the layout options provided by which-key.nvim. Here's what they offer:

layout = {
    height = { min = 4, max = 25 }, -- min and max height of the columns
    width = { min = 20, max = 50 }, -- min and max width of the columns
    spacing = 3, -- spacing between columns
    align = "left", -- align columns left, center or right
  }

Would you be happy with having the same set of options? That would give you the ability to center the content of the popup.

@TheBlob42 What are your thoughts on this?

@TheBlob42
Copy link
Owner

Sounds good to me 🙂 if it is easy to implement go for it.

From my memory it should now be possible to use "dictionaries" in the .ideavimrc to set such configuration in a map style instead of using the current "one variable per setting"-approach of the plugin, but you don't have to find out how this works. That is still something we can refactor later.

Would love to see a PR so I can easily compare how you implemented your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants