Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal crash after booting to title screen #11

Closed
arranreedman opened this issue Aug 13, 2016 · 17 comments
Closed

Fatal crash after booting to title screen #11

arranreedman opened this issue Aug 13, 2016 · 17 comments

Comments

@arranreedman
Copy link

About a second after booting to the title screen, the game crashes (crash log is linked below)
My theory is that another mod, 'menu mobs' causes a conflict with EnderStorage as on removing 'menu mobs' the problem does not occur

http://pastebin.com/LCa211nG

@covers1624
Copy link
Member

They must be doing some weird things to events, I'll look in to it later on today when I'm at my computer.

@arranreedman
Copy link
Author

Yeah, that was my guess... I just thought it would be best to let you know to avoid future issues e.t.c. glad I could help

@Morpheus1101
Copy link

Im getting this crash as well Log @ http://pastebin.com/N7Psu8Em very very minor diff between my crash report and the other .. but deff the same issue

@arranreedman
Copy link
Author

I don't know much about modding, I am just a user, so I have no idea what is causing your problem. It's not the end of the world for me because i didn't really need that other mod; i just wanted to let you guys know that there is an issue afoot!

@covers1624
Copy link
Member

Can i have a link to this mod causing the crash, the only way this could happen is if the world load event is not fired on the client..

@arranreedman
Copy link
Author

https://minecraft.curseforge.com/projects/menumobs
This is the one that I think caused it

@Morpheus1101
Copy link

Morpheus1101 commented Aug 23, 2016

I have this mod in my pack, have disabled it and testing now.... Ok after disabling the mod, i can confirm that menmobs is indeed the issue

@arranreedman
Copy link
Author

arranreedman commented Aug 23, 2016

The difference with the error that I came across and the one that the report it linked to is that the title screen had only just loaded when it crashed; I hadn't got around to making a world which is where the other error apears to have occured...

@arranreedman
Copy link
Author

But yes, I thought that menumobs was the issue... out of interest, do you think it is something you can fix on your end or should I send the same bug report to the other mod's creator?

@covers1624
Copy link
Member

I would hold of on reporting it to him as Morph has already done that, tomorrow ill investigate why this is happening in more depth and see if i can fix it for the other mod.

@arranreedman
Copy link
Author

Sounds good... glad I could help

@bschoenmaeckers
Copy link

bschoenmaeckers commented Aug 23, 2016

I'm defining mc.thePlayer to load a fake nonticking world. EnderStorage crashes at clientState.update() because onWorldLoad never has been called. The null check above it checks if mc().getConnection() != null wich will return true because mc.thePlayer.connection isn't null.
I propose to check in ClientUtils.inWorld() if mc().theworld != null instead of the connection if this wasn't done on purpose.

@Morpheus1101
Copy link

This has now been fixed

@bschoenmaeckers
Copy link

This hasn't been fixed right?

@covers1624
Copy link
Member

I was going off what Morph said.

@covers1624
Copy link
Member

So is this fixed now?

@bschoenmaeckers
Copy link

Yes it is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants