Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Add DeathLog mod support #108

Closed
1 task done
latipun7 opened this issue Feb 24, 2024 · 3 comments
Closed
1 task done

[Suggestion] Add DeathLog mod support #108

latipun7 opened this issue Feb 24, 2024 · 3 comments
Labels
Suggestion A feature request or some other suggestion.

Comments

@latipun7
Copy link

What is this suggestion for?

Mod Itself

Suggestion

DeathLog has a button to access death log on vanilla Statistics screen. Please add support to add DeathLog button on BSS.
Thank you.

Code of Conduct

  • I agree that I will be available later for any follow-up questions to help with implementing the suggested thing.
@latipun7 latipun7 added the Suggestion A feature request or some other suggestion. label Feb 24, 2024
@TheCSDev
Copy link
Member

TheCSDev commented Feb 25, 2024

Hello, and thank you for the suggestion!
Aside from this issue being a duplicate of #13, there are unfortunately technical limitations preventing me from implementing this feature.

In order for me to implement this, the other mod (in this case DeathLog), would have to provide some sort of API or something that functions like an API, that is reliable, and that other mod developers can use in order to open the DeathLog Screen from another mod such as this one.
Now, as you can probably already tell by now, DeathLog features no APIs. This basically means I do not have any tools to actually make this possible.

I did however, eventually make my own APIs for this mod, back in v3.0. As of right now, betterstats has APIs for various things, including:

  • Creating custom statistics tabs, and
  • Adding custom items to the menu-bar (likely what DeathLog wants)

And with the API I implemented into this mod, I am hoping other mod developers can do stuff to make their mods more available through this mod. I of-course, am trying to find ways (especially as of lately) to support other mods and their modded features, but in some cases such as this one, I simply don't have the tools to make it possible.

In other words, I am basically saying that perhaps the developer of DeathLog could either implement an API in their own mod, or use this mod's API to implement support themselves. If they or any other mod developer out there, ever needs help using my APIs, they may feel free to reach out to me and ask me anything.

So hopefully that explains things for you. If you need anything else or have any questions, feel free to let me know. As for this issue, I think it will have to be closed as "Not planned".
Have a great day (or night)!

Edit: typo fixes

@latipun7
Copy link
Author

Thank you for the reply, I understand.
Sorry, I forgot to search the issue before opening new issue 🙏

@TheCSDev
Copy link
Member

It's been quite a while since I posted gliscowo/deathlog#38
Given there is no response for now, I have decided to close this issue so it doesn't end up open indefinitely. If a way to implement this presents itself, then this issue may be reopened and the feature may be implemented.
Thanks again, and have a great day!

@TheCSDev TheCSDev closed this as not planned Won't fix, can't repro, duplicate, stale Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Suggestion A feature request or some other suggestion.
Projects
None yet
Development

No branches or pull requests

2 participants