Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Crash] On tap on articles in Bookmark app crashes. #1

Closed
AnkitGhate opened this issue Jul 20, 2020 · 1 comment
Closed

[Crash] On tap on articles in Bookmark app crashes. #1

AnkitGhate opened this issue Jul 20, 2020 · 1 comment

Comments

@AnkitGhate
Copy link
Contributor

Steps to reproduce :

  1. Add a bookmark
  2. Navigate to bookmarks and tap on any article
  3. App crashes.

Expected : App should navigate to article details.

Fix :
Bookmark seems to have wrong navigation path

newsAdapter.setOnItemClickListener { article ->
           ...
            findNavController().navigate(
                R.id.action_articlesFragment_to_articleDetailsFragment,
                bundle
            )
        }

It should be ,

newsAdapter.setOnItemClickListener { article ->
            val bundle = Bundle().apply {
                putSerializable("article", article)
            }
            findNavController().navigate(
                R.id.action_bookmarksFragment_to_articleDetailsFragment,
                bundle
            )
        }
@Spikeysanju
Copy link
Member

✅ Fixed bookmark navigation #2

@Spikeysanju Spikeysanju added good first issue Good for newcomers and removed good first issue Good for newcomers labels Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants