Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

b:commandLink #652

Closed
chongma opened this issue Mar 8, 2017 · 2 comments
Closed

b:commandLink #652

chongma opened this issue Mar 8, 2017 · 2 comments
Assignees
Milestone

Comments

@chongma
Copy link
Collaborator

chongma commented Mar 8, 2017

i looked at b:button and b:commandButton and neither have a target or href attribute as far as i could see. this is useful if you want to open something in a new tab. maybe this could be a superclass of commandLink?
btw where do i register interest in helping with the project? i have a couple of other things to mention about the documentation which i might be able to help with

  • it would be nice if it was ordered alphabetically as it is hard to scan for a
  • if there were links to the source code of the examples directly from the page, or maybe a snippet of the backing bean it would sometimes help to understand the use case
@stephanrauh
Copy link
Collaborator

<b:commandButton> doesn't need either attribute because it's meant to call JSF actions. However, it might be a good idea to add these attributes to <b:button>. Actually, I'm surprised we didn't implement it yet.

As for contributing: simply drop us a mail at "webmaster1 at beyondjava dot de". Like you, I think there's a lot to improve with our showcase :). Instead of sorting stuff alphabetically I'd prefer to offer a search field. Same idea, just differently implemented.

@stephanrauh
Copy link
Collaborator

Thanks for providing a pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants