Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizer for MCprep #239

Closed
StandingPadAnimations opened this issue Aug 22, 2021 · 7 comments · Fixed by #290
Closed

Optimizer for MCprep #239

StandingPadAnimations opened this issue Aug 22, 2021 · 7 comments · Fixed by #290
Assignees
Labels
enhancement Feature requests or new functionality suggestions

Comments

@StandingPadAnimations
Copy link
Collaborator

Currently, MCprep does some small optimizations to scenes in Cycles, but it would be nice to have a optimizer built for MC animation. Maybe 2 options(Quality and Speed) for CPU, CUDA, OptiX, and OpenCL. In later versions of Blender, we could also take advantage of adaptive sampling(perhaps a flag that tells MCprep that the user is using a later version of Blender)

@TheDuckCow
Copy link
Member

Would love to hear your thoughts of all the settings you'd apply! Let me know if you think differently, but this could be great for the "prep world" button (which tbh should probably be renamed to "optimize" or something like that, which is mostly what it does right now). We could definitely have a dropdown property for different "modes", and even be reactive based on Eevee or Cycles being selected.

@TheDuckCow TheDuckCow added the enhancement Feature requests or new functionality suggestions label Sep 6, 2021
@StandingPadAnimations
Copy link
Collaborator Author

StandingPadAnimations commented Sep 7, 2021

I think it could have light bounce optimization. Firstly by setting max light bounces to 8 and transparency to 12 and some manual input for the other bounces like:

How many glossy materials do you have?
[ ] None or not a lot(1 to 2 light bounces)
[ ] a lot(2 to 3 light bounces)

Preferably this would be a slider for better visualization(at least for the user). I would also suggest adaptive sampling but it wouldn't be useful for 2.7x users(though I guess it could just check the version of Blender and set a variable to true). Ill try working on a concept for how it might look

@TheDuckCow
Copy link
Member

Awesome, appreciate your willingness to mock it up! And yes, it shouldn't be a problem for use to insert some checks for "is blender 2.7x, then don't show XYZ option", MCprep already does that in a few places.

@StandingPadAnimations
Copy link
Collaborator Author

With Blender now getting Cycles X in the 3.0 release, the optimizer may also need another check for Cycles X features and changes

@StandingPadAnimations
Copy link
Collaborator Author

Ok, i'vs started work on it while testing some stuff for #273. I just need to iron out some bugs and make the UI easier to work with before submitting a pull request

@TheDuckCow
Copy link
Member

TheDuckCow commented Apr 18, 2022 via email

@StandingPadAnimations
Copy link
Collaborator Author

I will close this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or new functionality suggestions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants