Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-blender reported bugs #261

Closed
10 of 13 tasks
TheDuckCow opened this issue Dec 24, 2021 · 7 comments
Closed
10 of 13 tasks

In-blender reported bugs #261

TheDuckCow opened this issue Dec 24, 2021 · 7 comments
Labels
Milestone

Comments

@TheDuckCow
Copy link
Member

TheDuckCow commented Dec 24, 2021

Listing below a barrage of bug reports that have multiple loggers. I will attempt to resolve all of these bugs, knowing some of them are blender version specific. ID's listed here are from the MCprep issue reporting database, which I use privately to track fixes. These are ordered in frequency of reports and number of users. Likely not all will be resolved for the target milestone. These are the top 11 I am focussing on for this iteration, will edit if others are resolved and reference this on release update.

  • -Mq_H0YG4q07eAC8CDlp: AttributeError: Calling operator "bpy.ops.object.proxy_make" error, could not be found\n (a blender 3.0 error) #262
  • -MobC6QO1QmbzwxXV0XE: moonmesh.parent = get_time_object()\nTypeError: bpy_struct: item.attr = val: Object.parent ID type does not support assignment to itself\n
  • -MrYyXulO3-4rR0Dlfo-: UnicodeDecodeError: 'utf-8' codec can't decode byte 0x8b in position 1: invalid start byte\n, This is actually an issue with the obj files themselves, but MCprep could do better about telling the user something useful like "Try re-exporting your world" or "World cannot be read, may be corrupted". At the risk of PII I may consider also logging filenames, since this happens frequently enough it's worth understanding what people are actually attempting to do (are they selecting .zip files or something?)
  • -MfrrPFH3udKVFiitSLr: context.object.material_slots[mat_ind].material = mat\nAttributeError: bpy_struct: attribute "material" from "MaterialSlot" is read-only\n
  • -Mpl6MOu1M6JEgEpTfaS: enum "Non-Color" not found in ('Linear', 'sRGB') (many variations of this one, may not be able to do much about it)
  • -MhJp--Z7JIfZnnw45w1: During item spawning (from list or file): RuntimeError: Operator bpy.ops.object.mode_set.poll() failed, context is incorrect\n, I am doubtful I'll be able to find a simple fix for this one and seems very contextual. A geometry nodes alternate may be viable, though not backwards compatible.
  • -MoSSh6nd09YGfF7gEp_: loops_uv = tuple(uv for (_, _, face_vert_tex_indices, _, _, _, _) in faces\n File "<addon_path>/import_obj.py", line 738, in \n for uv in verts_tex[face_uvidx]
  • -MhwacqY_LI2NQ-7TijV: asum += data[fnd][image.size[1]*row + col]\nIndexError: list index out of range\n (likely related to the above)
  • -MgRXi1HSdOt7R23ZAZx: method, block = self.block.split("/")\nValueError: not enough values to unpack (expected 2, got 1)\n, should more gracefully recover from this, though may be a legitimate upstream bug.
  • -MhtywSS5IU1Wwc9WvlI: RuntimeError: Error: Image 'water_still-seq-temp.001' could not be saved to 'textures\water_still\water_still_0001.png'\n\n, Let's at least create a better logging statement and more narrowly capture what error occurred to give a useful instruction (e.g. permission error? diskspace?)
  • -Mm8BSy1cLw9UgTAdlAt: Looks like an os path based issue: ...mcprep_default/assets\minecraft\textures\block\grass_block_side.png': No such file or directory\n\n
  • -Mp-x0eXahGbiDeA3mkM mcmeta = json.load(mcf), raise JSONDecodeError("Expecting value", s, err.value)
  • -MfnEBOpGxyEReFtGtNU load_linked\n act = context.selected_objects[0]

If anyone is curious about how issue tracking works, please see more information here.

@TheDuckCow TheDuckCow added the bug label Dec 24, 2021
@TheDuckCow TheDuckCow added this to the v3.2.6 milestone Dec 24, 2021
@StandingPadAnimations
Copy link
Collaborator

  • -MrYyXulO3-4rR0Dlfo-: I'd suggest having a try catch loop to handle the errors
  • -Mm8BSy1cLw9UgTAdlAt: This seems interesting. I'd assume filepaths were done in a cross platform way(though this could be a Windows issue). I'll take a closer look once I get back from vacation
  • -Mpl6MOu1M6JEgEpTfaS: This one is also pretty interesting. If the reports have Blender versions, which version has this issue the most. This might be fixed with a try catch loop. My suspicion is that it's a issue in older versions of Blender.

@StandingPadAnimations
Copy link
Collaborator

All of these seem interesting, but I'll have to take a look when I get back

@TheDuckCow
Copy link
Member Author

Sounds good! I'll not focus on those ones first, but if I do finish other tasks up I'll comment back here before working on them to avoid any overlap. No rush and no worries if you don't end up having time, appreciate your willingness!

@TheDuckCow
Copy link
Member Author

FYI I'm going to start tackling a few of these which are most critical, I'll be fixing the following at a minimum hopefully:

  • -Mq_H0YG4q07eAC8CDlp
  • -MobC6QO1QmbzwxXV0XE

Any that you get to that I don't can still be included in a near-after update of course! And if I end up ambitiously solving more than the two above, I'll tick the boxes above as complete.

TheDuckCow added a commit that referenced this issue Dec 31, 2021
This resolves issue  mentioned in #261
TheDuckCow added a commit that referenced this issue Dec 31, 2021
May help address some reports such as  as listed in #261
@TheDuckCow TheDuckCow modified the milestones: v3.2.6, v3.2.7, v3.4.0, v3.3.1 Jan 2, 2022
TheDuckCow added a commit that referenced this issue Apr 22, 2022
This removes the string concat which is prone to errors, and had at least one error report: -Mw6vXKxlj_b3pou5GOR per #261 listed as -MgRXi1HSdOt7R23ZAZx
TheDuckCow added a commit that referenced this issue May 3, 2022
@TheDuckCow
Copy link
Member Author

Marking -Mm8BSy1cLw9UgTAdlAt resolved with 55719ce

@TheDuckCow
Copy link
Member Author

TheDuckCow commented May 3, 2022

Marking -MhtywSS5IU1Wwc9WvlI as "done" but really nothing was or could be done. It could be due to any number of OS issues, and specific errors are not passed forward by the function call to save the image constructed. Very few people have run into this.

Marking -MoSSh6nd09YGfF7gEp_ as done as it is already handled with try/except around the obj importer operator (this is not actually MCprep code).

Marking -MhwacqY_LI2NQ-7TijV as a try-except was added around the one line. Still seems like a bug that we need to try catch at all here, but will unblock some users hopefully.

Have not seen a way to resolve -MfrrPFH3udKVFiitSLr, but I do not only 4 reports of this happening, and all blender 3.0+ on Windows and some (not all) from the current version of MCprep.

@TheDuckCow
Copy link
Member Author

Marking this issue as closed; not all were resolved, but enough that we shouldn't hold up future development as well as other now more commonly auto reported bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants