Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update warp safety with blocks from 1.8 to 1.11 #117

Closed
TheE opened this issue Nov 19, 2016 · 1 comment
Closed

Update warp safety with blocks from 1.8 to 1.11 #117

TheE opened this issue Nov 19, 2016 · 1 comment
Assignees
@TheE
Labels
c: bukkit-imp Affects the Bukkit version. s: fixed The issue has been resolved. t: enhancement An improvement of an existing function.
Milestone
3.0

Comments

@TheE
Copy link
Member

TheE commented Nov 19, 2016

Due to the discontinuation of the 'official' Bukkit, MyWarp is currently still build against Bukkit 1.7.10. While I have made sure that it works with versions of CraftBukkit and Spigot released for newer Minecraft versions, it is my intention to continue supporting 1.7.10 and thus not relying on API additions done beyond 1.7.10.

However, the warp safety implementation of mywarp-bukkit has no support for any unsafe blocks added beyond 1.7. This should be changed, maybe be rewriting the warp safety to use a modular system with individual block definitions for each Minecraft version.
@TheE TheE added c: bukkit-imp Affects the Bukkit version. t: enhancement An improvement of an existing function. labels Nov 19, 2016
@TheE TheE added this to the 3.0 milestone Nov 19, 2016
@TheE TheE self-assigned this Nov 19, 2016
TheE added a commit that referenced this issue Dec 11, 2016
@TheE
Build against Bukkit 1.11, update MaterialInfo with Materials added s…
7fae177 
…ince 1.7

The Bukkit version of Minecraft is still fully compatible with Minecraft 1.7.9; it now supports any Minecraft version from 1.7.9 to 1.11. This means that any API added after Bukkit 1.7.9 must not be used in 'mywarp-bukkit' (Materials are used in switch-case only which is fine)!

Adds #117.
@TheE
Copy link
Member Author

TheE commented Dec 11, 2016

Turns out, switch-case works even if a enum field does not exist.

@TheE TheE closed this as completed Dec 11, 2016
@TheE TheE added the s: fixed The issue has been resolved. label Dec 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheE TheE

Labels
c: bukkit-imp Affects the Bukkit version. s: fixed The issue has been resolved. t: enhancement An improvement of an existing function.
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
1 participant
@TheE