Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make resource bundles user configurable #33

Closed
TheE opened this issue Feb 26, 2015 · 1 comment
Closed

Make resource bundles user configurable #33

TheE opened this issue Feb 26, 2015 · 1 comment
Assignees
@TheE
Labels
c: bukkit-imp Affects the Bukkit version. c: core Affects the core. t: enhancement An improvement of an existing function.
Milestone
3.0-beta-2

Comments

@TheE
Copy link
Member

TheE commented Feb 26, 2015

In MyWarp 2.6, the resource bundles where read from disk so that server owners could configure them to their liking and add their own. If this behaviour is still required, resource bundles should be stored in a folder in the platform's data folder using FolderSourcedControl. They need to be updated whenever new keys are added, this could be done using the PropertiesUtils.

However this behaviour might not be needed if MyWarp comes with a few more bundled localizations.
@TheE TheE added t: enhancement An improvement of an existing function. c: bukkit-imp Affects the Bukkit version. labels Feb 26, 2015
@TheE TheE self-assigned this Feb 26, 2015
@TheE TheE added this to the 3.0 milestone Feb 26, 2015
@veteranmina veteranmina mentioned this issue Mar 13, 2015
Closed
@TheE TheE mentioned this issue Mar 26, 2015
Closed
@TheE TheE modified the milestones: 3.0-beta-2, 3.0 Jun 8, 2015
@TheE
Copy link
Member Author

TheE commented Jun 16, 2015

After some consideration, the system will work as follows and is implemented in a RessourceBundle.Control implementation bundled, but not enforced, by the core:

  • Users may override bundled resource bundles or add entirely new ones by putting them in a special folder inside of MyWarp's plugin folder.
  • These files will not be updated in any way, missing keys are resolved via the standard bundle lookup order.
  • The root resource bundle cannot be overwritten.
  • Folder and files will not be created automatically. By default only bundled files will be used.
  • Files will use UTF-8 (as they do now).

Additionally localizations wil be crowd-sourced at a best-effort basis.

@TheE TheE added the c: core Affects the core. label Jun 16, 2015
TheE added a commit that referenced this issue Jun 18, 2015
@TheE
Allow addition of external new resource bundles as well as replacemen…
b17de12 
…t of existing ones

- Users may override bundled resource bundles or add entirely new ones by putting them in the 'lang' folder inside of MyWarp's plugin folder. Bundles must be placed in sub-folders that mirror MyWarp's package structure and named accordingly (e.g. 'me/taylorkelly/mywarp/lang/Commands_de.properties' overwrites the bundled german bundle).
- Custom files will not be updated in any way, missing keys are resolved via the standard bundle lookup order.
- The root resource bundle cannot be overwritten.
- Folder and files will not be created automatically. By default only bundled files will be used.

Adds #33.
@TheE TheE closed this as completed Jun 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheE TheE

Labels
c: bukkit-imp Affects the Bukkit version. c: core Affects the core. t: enhancement An improvement of an existing function.
Projects
None yet
Milestone
3.0-beta-2
Development

No branches or pull requests
1 participant
@TheE