Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile Menu Arrow Not Shown for Span Parents #45

Closed
sprankhub opened this issue Aug 3, 2016 · 2 comments
Closed

Mobile Menu Arrow Not Shown for Span Parents #45

sprankhub opened this issue Aug 3, 2016 · 2 comments

Comments

@sprankhub
Copy link
Collaborator

In the mobile menu, an arrow is shown for links which have child elements, so that the user knows that there is something "behind" the link. The link could also be a span tag. Currently, there is no arrow for span elements which have child elements. In order to fix this, skin/frontend/base/default/scss/theextensionlab/megamenu/responsive.scss has to be edited.

Old selectors:

.megamenu-nav-primary li.parent > a:after {...}
[...]
.megamenu-nav-primary li.parent.menu-active > a:after {...}

New selectors:

.megamenu-nav-primary li.parent > a:after, .megamenu-nav-primary li.parent > span:after {...}
[...]
.megamenu-nav-primary li.parent.menu-active > a:after, .megamenu-nav-primary li.parent.menu-active > span:after {...}
@JamesAnelay
Copy link
Member

Sorry for such a late reply here Simon!
Quite right this is now fixed here : ab2db6e

I will fold this on when I create a release for the SID issue.

Thanks again!

@sprankhub
Copy link
Collaborator Author

Thanks James! But you still have to run SASS again, so that the CSS files are changed as well :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants