Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] CortexNeurons error parsing version in analyzer.json or responder.json #901

Closed
azgaviperr opened this issue Nov 16, 2020 · 7 comments
Assignees
Labels
category:bug Issue is related to a bug priotiry:high

Comments

@azgaviperr
Copy link

Describe the bug
While the version of analyzer is described in the manifest contain a "x.0", Cortex try to pull only the tag x instead of x.0.
Maybe this is due to a script converting it as number instead of string.

To Reproduce
Steps to reproduce the behavior:

  1. Try to execute the responder redmine as it is delcared as 2.0 and don't have a tag: 2 on dockerhub
  2. See cortex failing to find a suitable image for this responder.

Expected behavior

It should be possible de download the proper image version declared in the manifest if it containe x.0

@azgaviperr azgaviperr added the category:bug Issue is related to a bug label Nov 16, 2020
@dadokkio
Copy link
Contributor

Hello, are you sure the responder is redmine 2.0? The version in the json is 1.0 and that could explain why the docker image for 2.0 is not available

@azgaviperr
Copy link
Author

Sorry, I mispell it, yes it's 1.0

@azgaviperr
Copy link
Author

The issue seems to be interpreting 1.0 as a value and use it as an "int" so "1.0" become "1" instead of a float as Emlparser which is 1.2 is properlly pulled.

@dadokkio
Copy link
Contributor

I'm running few docker images tagged as 1.0 without issues.. can you please add the related error from cortex?

@azgaviperr
Copy link
Author

docker pull cortexneurons/redmine_issue:1 Error image not found

Sorry got an issue with the rate limit right now, but the message was pretty much that

@dadokkio
Copy link
Contributor

Ok, I was able to replicate the issue. I was using the -devel.json list and there the image was fine.
@jeromeleonard probably drone for master must be rerun in order to finalize "recently added" analyzer/responder images. Can you please check?

@jeromeleonard
Copy link
Contributor

we are looking at it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:bug Issue is related to a bug priotiry:high
Projects
None yet
Development

No branches or pull requests

3 participants