Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] CheckPhish Analyzer #997

Closed
pjuhas opened this issue Jun 3, 2021 · 1 comment · Fixed by #1000
Closed

[FR] CheckPhish Analyzer #997

pjuhas opened this issue Jun 3, 2021 · 1 comment · Fixed by #1000
Labels
category:new-analyzer New analyzer submitted
Milestone

Comments

@pjuhas
Copy link
Contributor

pjuhas commented Jun 3, 2021

Feature description
Detailed analysis of URL via CheckPhish. Returns URL to analysis and screenshot of site.

Describe the solution you'd like
Query CheckPhish API to create analysis of URL.

Additional context
Provide your API key from CheckPhish as a value of the key parameter.

@pjuhas pjuhas changed the title [FR] [FR] CheckPhis Analyzer Jun 3, 2021
@pjuhas pjuhas changed the title [FR] CheckPhis Analyzer [FR] CheckPhish Analyzer Jun 3, 2021
@nadouani nadouani linked a pull request Jul 21, 2021 that will close this issue
@nadouani nadouani added this to the 3.1.0 milestone Jul 21, 2021
@nadouani nadouani added the category:new-analyzer New analyzer submitted label Jul 21, 2021
@cyberpescadito
Copy link
Contributor

Hello @pjuhas, thanks for your contribution !

Would it be possible to make only one analyzer of these two, that will wait for the job to be completed on CheckPhish side, and provide the result when the analysis result is available?

Having two different analyzers that you must chain to have the result is not an intuitive workflow and we want to keep things simple as possible for analysts. It also prevents to add an observable to get the report.

Additionally, downloading the screenshot and display it in the report would be a very valuable improvement, instead of providing the url to the screenshot.

What do you think about it?

PS: the py file shebang is pointing to python2, which is deprecated

Thanks again for your contribution, much appreciated !

@nadouani nadouani modified the milestones: 3.1.0, 3.2.0 Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-analyzer New analyzer submitted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants