Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identical URL Observables can still be added multiple times to the same case #1756

Closed
Passimist opened this issue Jan 21, 2021 · 3 comments
Closed
Assignees
Labels
bug TheHive4 TheHive4 related issues
Milestone

Comments

@Passimist
Copy link

Passimist commented Jan 21, 2021

Reopen of issue at the bottom of this post:

@To-om @nadouani Hi guys, I hope you had a nice start into the new year! Can you please reopen this issue?
I just upgraded to TheHive 4.0.3 and I can still upload identical url observables via TheHive4py (not the latest thehive4py version but the one before EDIT tried it with the newest thehive4py version and issue occurrs there aswell).
image
image
If I can provide any additional information to help fix this please let me know.
Some information that may help:
Submitted via thehive4py
Submitted almost at the same time
Observables have different observable IDs
This does not always work (but quite often as far as I can tell)
EDIT: As a workaround I now use a filelock to prevent simulaneous creation of identical URL observables. So far this helped preventing the bug. If this is a fix then it might be some kind of race condition? I ll update if the problem occurrs with this workaround in the next few days.

Originally posted by @Passimist in #1718 (comment)

@rriclet rriclet added bug TheHive4 TheHive4 related issues labels Jan 21, 2021
@nadouani
Copy link
Contributor

nadouani commented Mar 8, 2021

Hello @Passimist we will take a look at this an give you an answer / a fix

@nadouani nadouani added this to the 4.1.0 milestone Mar 8, 2021
@Passimist
Copy link
Author

Great, let me know if you need any information! Since I prevented simultaneous URL observable creation in my code that uses thehive4py (with a file lock and 5sec sleep after claiming the lock) the issue did not occurr again.

@To-om
Copy link
Contributor

To-om commented Mar 9, 2021

This issue is already fixed in 4.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug TheHive4 TheHive4 related issues
Projects
None yet
Development

No branches or pull requests

4 participants